[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: hurd-i386 updates



On Thu, Jul 29, 2004 at 03:31:50AM -0500, Branden Robinson wrote:
> > I'm no PAM guru, so I don't know about that change (I've seen Branden
> > has marked it as TODO on top of #800),
> 
> Technically, it's marked XXX, which means I don't know what to do about it.
> I'm leaving it up the actual Hurd porters to tell me.

Well, the current patch works, so I guess there is no reason to keep it
out.
 
> I actually don't understand the above; sorry.

Not sure which part of the following two you are referring to here, so I
elaborate on both:

> > but I merged that back from my intial diff and the build was fine (I did
> > not try building without 'define PamLibraries'). 

xfree86[...]-6 had PamLibraries defined, while current SVN does not. I
haven't tried to build the unpatched SVN trunk, but as hurd-i386 has
those libraries, I see no reason why gnu.cf should differ from linux.cf
here today, even more so as xfree86 builds fine with them. Also,
PamMiscLibraries are avaible as well, so I added those.

> > Changing the cpp command line is only needed for k*BSD AFAIK, but it
> > does not hurt to sync that with linux.cf as well.
 
+-#ifndef
+-#define CppCmd                        /lib/cpp
++#ifndef CppCmd
++#define CppCmd                        /usr/bin/cpp

I was under the impression that k*BSD does not have a /lib/cpp symlink
and that's why the patch is in there. As the symlink is present on
GNU/Linux as well, I rather assume that GNU/Hurd did not have
/usr/bin/cpp back in the days.

Well, either way works, but it is /usr/bin/cpp in linux.cf as well, so
this syncs this back. This part of the patch is probably not required
though, so if you don't like it, just drop it.

> I'll also take care of updating the mir-false-* files.

Oh, another thing I didn't know about :)


Michael



Reply to: