On Fri, Feb 20, 2004 at 12:58:52PM +0000, Andreas Metzler wrote: > X Strike Force SVN Repository Admin <branden+svnadmin@deadbeast.net> wrote: > [...] > > Log: > > Stop passing -q to fgrep if we actually want output from it. Duh. > > Thanks again to Filip Van Raemdonck. > [...] > > observe "removing $dir directory from $ldsoconf" > > - fgrep -qsvx "$dir" "$ldsoconf" > "$ldsoconf.dpkg-tmp" > > + fgrep -svx "$dir" "$ldsoconf" > "$ldsoconf.dpkg-tmp" > > mv "$ldsoconf.dpkg-tmp" "$ldsoconf" > > fi > > fi > > As noted by Filip Van Raemdonck in #233645 you'll also need to add > '|| true'. > > Otherwise if $ldsoconf contains _only_ $dir then > 'fgrep -svx "$dir" "$ldsoconf' will return an error and the script will > exit prematurely. Oh, d'oh. This means the fix I just checked in is bogus. I didn't think about it the right way around. Thank you VERY much for eyeballing the commit diff. That's what it's there for. As we can already see from the 4.3.0-3 changelog, I do make plenty of dumb mistakes, and it's nice to catch them before they end up in a shipping package. > BTW Thanks for the work. Thank *you*! -- G. Branden Robinson | If you wish to strive for peace of Debian GNU/Linux | soul, then believe; if you wish to branden@debian.org | be a devotee of truth, then http://people.debian.org/~branden/ | inquire. -- Friedrich Nietzsche
Attachment:
signature.asc
Description: Digital signature