Re: where all these codenames came from Page not found
Hi Kevin,
Kevin Thomas <kevin.t0517@gmail.com> wrote:
> On Tue, Apr 21, 2020 at 10:04:50AM +0800, Paul Wise wrote:
> > Usually this means that the translation-check header is pointing at an
> > outdated commit so the translation is deemed to be out of date and thus
> > updating the translation with your changes will not bring it up to date
> > with earlier changes from before your commit, so the translation-check
> > header should not be updated. Once a translator reads through the
> > earlier changes and your changes they will update the translation and
> > also update the translation-check header.
The situation explained above was however not the problem here.
Looking at the logs shows, that you only executed
'./smart_change.pl <all-the-filenames>'
which would only modify the commit hashes, and not more.
That, however, is not, what is meant when pabs said "make sure you also use
smart_change.pl to update all the translations".
Obviously the links to the FAQ need to be changed in the translations as
well, and when that's done, one can update the hash values as well.
I realize that the use of the smart_change.pl script is not intuitive and
well documented, though.
> > The smart_change.pl script doesn't work very well when there are chains
> > of translations starting from languages other than English (especially
> > since we didn't decide to use file hashes in the headers, unfortunately
> > instead going with commit hashes), but I don't think this is the
> > situation for your patch.
>
> Ah okay, thanks for the information! In that case I will leave the merge
> request as-is.
Done, including translations.
Holger
--
Holger Wansing <hwansing@mailbox.org>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508 3529 59F1 87CA 156E B076
Reply to: