Bug#760188: ITP: scoop -- concurrent parallel programmming library
copyright review
I used licensecheck as a starting point
can you look with the upstream to add copyright headers where it is missing UNKOWN
and it would be nice to have also the copyright in each header.
it seems thaht there is only the license without the copyright statement.
this is not a blocker but it is good practive and this way no ambiguity.
This way your next license check will be easyer.
/tmp/scoop-0.7.1$ licensecheck -r *
doc/conf.py: *No copyright* GENERATED FILE
examples/map_doc.py: *No copyright* LGPL (v3 or later)
examples/recurse.py: *No copyright* LGPL (v3 or later)
examples/url_fetch.py: *No copyright* LGPL (v3 or later)
examples/lambda.py: *No copyright* LGPL (v3 or later)
examples/object.py: *No copyright* LGPL (v3 or later)
examples/full_tree.py: *No copyright* LGPL (v3 or later)
examples/grtest.py: *No copyright* UNKNOWN
examples/callback.py: *No copyright* LGPL (v3 or later)
examples/url_fetch_doc.py: *No copyright* LGPL (v3 or later)
examples/map_scan.py: *No copyright* LGPL (v3 or later)
examples/deap_ga_evosn.py: *No copyright* LGPL (v3 or later)
examples/testmut.py: *No copyright* LGPL (v3 or later)
examples/deap_ga_onemax.py: *No copyright* LGPL (v3 or later)
examples/sum_multiples.py: *No copyright* LGPL (v3 or later)
examples/shared_example_doc.py: *No copyright* LGPL (v3 or later)
examples/pi_calc_doc.py: *No copyright* LGPL (v3 or later)
examples/conditional_import.py: *No copyright* LGPL (v3 or later)
examples/conditional_execution.py: *No copyright* LGPL (v3 or later)
examples/shared_example.py: *No copyright* LGPL (v3 or later)
examples/sorting.py: *No copyright* LGPL (v3 or later)
examples/dependency/sortingnetwork.py: *No copyright* LGPL (v3 or later)
examples/map_reduce.py: *No copyright* LGPL (v3 or later)
examples/tree/Tree.py: *No copyright* UNKNOWN
examples/tree/dtm-tree.py: *No copyright* UNKNOWN
examples/tree/TreeGen.py: *No copyright* UNKNOWN
examples/tree/scoop_tree.py: *No copyright* UNKNOWN
examples/tree/serial-tree.py: *No copyright* UNKNOWN
examples/pi_calc.py: *No copyright* LGPL (v3 or later)
examples/rssDoc.py: *No copyright* LGPL (v3 or later) GENERATED FILE
examples/map_as_completed.py: *No copyright* LGPL (v3 or later)
examples/interactive_shell.py: *No copyright* UNKNOWN
examples/image_resize.py: *No copyright* LGPL (v3 or later)
examples/tree_traversal.py: *No copyright* LGPL (v3 or later)
examples/exceptExample.py: *No copyright* LGPL (v3 or later)
scoop/fallbacks.py: *No copyright* LGPL (v3 or later)
scoop/__init__.py: *No copyright* LGPL (v3 or later)
scoop/encapsulation.py: *No copyright* LGPL (v3 or later)
scoop/_comm/__init__.py: *No copyright* LGPL (v3 or later)
scoop/_comm/scoopzmq.py: *No copyright* LGPL (v3 or later)
scoop/_comm/scooptcp.py: *No copyright* LGPL (v3 or later)
scoop/_comm/scoopexceptions.py: *No copyright* LGPL (v3 or later)
scoop/backports/newCollections.py: *No copyright* LGPL (v3 or later)
scoop/backports/dictconfig.py: UNKNOWN
scoop/backports/runpy.py: *No copyright* UNKNOWN
scoop/launcher.py: *No copyright* LGPL (v3 or later)
scoop/utils.py: *No copyright* LGPL (v3 or later)
scoop/_control.py: *No copyright* LGPL (v3 or later)
scoop/discovery/minusconf.py: *No copyright* UNKNOWN
scoop/discovery/__init__.py: *No copyright* LGPL (v3 or later)
scoop/launch/__init__.py: *No copyright* LGPL (v3 or later)
scoop/launch/workerLaunch.py: *No copyright* LGPL (v3 or later)
scoop/launch/brokerLaunch.py: *No copyright* LGPL (v3 or later)
scoop/_debug.py: *No copyright* LGPL (v3 or later)
scoop/broker/brokertcp.py: *No copyright* LGPL (v3 or later)
scoop/broker/structs.py: *No copyright* LGPL (v3 or later)
scoop/broker/brokerzmq.py: *No copyright* LGPL (v3 or later)
scoop/broker/__main__.py: *No copyright* LGPL (v3 or later)
scoop/shared.py: *No copyright* LGPL (v3 or later)
scoop/bootstrap/__main__.py: *No copyright* LGPL (v3 or later)
scoop/_types.py: *No copyright* LGPL (v3 or later)
scoop/__main__.py: *No copyright* LGPL (v3 or later)
scoop/futures.py: *No copyright* LGPL (v3 or later)
setup.py: *No copyright* UNKNOWN
test/tests_stopwatch.py: *No copyright* UNKNOWN
test/tests_stat.py: *No copyright* UNKNOWN
test/tests.py: *No copyright* LGPL (v3 or later)
test/tests_parser.py: *No copyright* UNKNOWN
now
the sourc epacakge contain already build documentation.
for exemple the
doc/_static directory contain .js code which is part of sphinx, you should indicate this in the copyright file.
Or better ask the upstream to remove this prebuild documentation.
what about _static/copybutton.js ?
* doc/blu.diff ??? this should be removed from the source package.
* doc/_template/* sphinx ?
* doc/_themes/* ???
it sems thah some files hase the DEAP license header. This should be fixed by the upstream or indicated in the copyright file.
picca@ORD03037:/tmp/scoop-0.7.1$ rgrep DEAP *
examples/deap_ga_onemax.py: raise Exception("This test needs DEAP to be installed.")
examples/dependency/sortingnetwork.py:# This file is part of DEAP.
examples/dependency/sortingnetwork.py:# DEAP is free software: you can redistribute it and/or modify
examples/dependency/sortingnetwork.py:# DEAP is distributed in the hope that it will be useful,
examples/dependency/sortingnetwork.py:# License along with DEAP. If not, see <http://www.gnu.org/licenses/>.
* In scoop/backports a few files where copyed from python something can you clarify this ?
exemple: ./backports/runpy.py
thanks for your efforts.
Frederic
Reply to: