Bug#760188: ITP: scoop -- concurrent parallel programmming library
Hello, here a quick review of all the patches
* dropped docs package (REJECT-FAQ: split this only if it's big)
I think that this patch should be reverted.
The problem if you add the documentation in python-scoop seems to me problematic when python3-scoop will come.
It is best to my opinion especially for the python pacakging to put the documentation nto a dedicated package which can be recommended by python2 and python3.
I do not think that this -doc package would be rejected by ftp-master. There argument is understandable when you have only one binary pacakge.
But here we can intall python2 and/or python3 version but in both cases you want the documentation.
* finalized
ok, do not hesitate to use cme to fix your control file.
* changelog: restored 'initial release' and added info on previous package
is there common binary packages between this old scoop package and the new one ?
* build docs package
ok
* running testsuite
nice to have a test suite. You can look at the debci and autopkgtest infrastructure to implement also the integration continuous integration for scoop.
* changelog: improved package info
* copyright: indent correction
ok
* control: corrected dependency, copyright: shortened too long line
why did you removed the virtual package ssh-client ?
* added no-adsense.patch
could you discuss with the upstream to remove these privacy breach things.
If they really want them, it should be nice to have a setup.py flag which allow to get rid of these google analytic links, instead of carrying a dedicated patch all the time.
* updated some files in deb/, removed source/local-options and egg-info, added examples and doc-base
You removed the local-options (are you using gbp-buildpackage to build scoop ?)
So I will consiede the pacakge ready for upload once
1) you regenerate the -doc package (this will simplify thinks when python3 pacakge will be possible)
2) re-add the ssh-client dependency (cheap)
3) add the autopkgtest part (will simplify a lot the maintenance of the package, so important for me)
I need to build it and do the copyright check.
then I think that it will be ok for me to sponsor the upload.
Cheers
Frederic
Reply to: