Bug#673424: bbswitch packaging
On Thu, Mar 21, 2013 at 11:01 AM, Ritesh Raj Sarraf <rrs@researchut.com> wrote:
> On Thursday 21 March 2013 10:34 PM, Vincent Cheng wrote:
>>
>> NEWS is already installed by dh_installdocs. But if you want to use
>> dh_installchangelogs for that instead, I'm fine with that; do you want
>> me to remove debian/docs as well then? I don't see the point of having
>> duplicate copies.
>
> Yes. Please. The upstream NEWS file has nothing but the changelog. And
> also, the concept of README.Debian and NEWS.Debian are specific to
> Debian, afaik.
Done.
>>> * bbswitch.c source file has no copyright header. It is good practice to
>>> have upstream's copyright declaration in each file.
>> It's been added as of bbswitch 0.6.
>
> I don't see it on github. The MODULE_AUTHOR has the name but without the
> copyright header it is unclear who all contributed to it.
>
> This is no big deal. I will upload otherwise also. It is just FYI.
Oops, I thought you meant the license header. Fair enough, I'll make a
note to ask upstream about that.
>>> * bbswitch does not Recommend / Suggest bumblebee package. Is it
>>> intentional? Is bbswitch useful all alone on its own?
>> Well, bbswitch should work fine on its own for users who don't want to
>> use their discrete nvidia gpu, and just want power savings (by turning
>> off the nvidia card with the bbswitch kernel module). Suggesting
>> bumblebee sounds like a good idea though.
>
> Thanks. I will pull back your changes soon after dinner. And hopefully
> will upload it. :-)
Done. Please feel free to upload bbswitch whenever you want. I have a
few more last-minute changes for bumblebee+primus in response to
feedback from upstream, but by the time you read this, I should've
already committed them to the git repo for you to review. :)
Regards,
Vincent
Reply to: