Bug#673424: bbswitch packaging
On Thu, Mar 21, 2013 at 6:35 AM, Ritesh Raj Sarraf <rrs@researchut.com> wrote:
> On Wednesday 20 March 2013 03:39 PM, Vincent Cheng wrote:
>> http://www.ugrad.cs.ubc.ca/~b2c8/debian/pkg-nvidia/bbswitch_0.6-1.dsc
>>
> Here's some feedback for package bbswitch.
>
> * Upstream changelog is not shipped. Lintian warns about it. Good to
> have. I have fixed it and will send you the patch. You add it to the
> repo for me. Meanwhile I'll raise a request to add me to pkg-nvidia.
NEWS is already installed by dh_installdocs. But if you want to use
dh_installchangelogs for that instead, I'm fine with that; do you want
me to remove debian/docs as well then? I don't see the point of having
duplicate copies.
> * bbswitch.c source file has no copyright header. It is good practice to
> have upstream's copyright declaration in each file.
It's been added as of bbswitch 0.6.
> * bbswitch does not Recommend / Suggest bumblebee package. Is it
> intentional? Is bbswitch useful all alone on its own?
Well, bbswitch should work fine on its own for users who don't want to
use their discrete nvidia gpu, and just want power savings (by turning
off the nvidia card with the bbswitch kernel module). Suggesting
bumblebee sounds like a good idea though.
Regards,
Vincent
Reply to: