On Wednesday 20 March 2013 03:39 PM, Vincent Cheng wrote: > http://www.ugrad.cs.ubc.ca/~b2c8/debian/pkg-nvidia/bbswitch_0.6-1.dsc > Here's some feedback for package bbswitch. * Upstream changelog is not shipped. Lintian warns about it. Good to have. I have fixed it and will send you the patch. You add it to the repo for me. Meanwhile I'll raise a request to add me to pkg-nvidia. * bbswitch.c source file has no copyright header. It is good practice to have upstream's copyright declaration in each file. * bbswitch does not Recommend / Suggest bumblebee package. Is it intentional? Is bbswitch useful all alone on its own? Ritesh -- Ritesh Raj Sarraf RESEARCHUT - http://www.researchut.com "Necessity is the mother of invention."
From 5113289bdc9a7935feda33a5cdbd96af19839cf8 Mon Sep 17 00:00:00 2001 From: Ritesh Raj Sarraf <rrs@debian.org> Date: Thu, 21 Mar 2013 18:50:33 +0530 Subject: [PATCH] Ship upstream changelog Signed-off-by: Ritesh Raj Sarraf <rrs@debian.org> --- debian/rules | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/rules b/debian/rules index edf3426..20628b1 100755 --- a/debian/rules +++ b/debian/rules @@ -26,3 +26,5 @@ override_dh_auto_install: dh_install -p$(pkgname) Makefile usr/src/$(name)-$(version) dh_install -p$(pkgname) bbswitch.c usr/src/$(name)-$(version) +override_dh_installchangelogs: + dh_installchangelogs NEWS -- 1.7.10.4
Attachment:
signature.asc
Description: OpenPGP digital signature