[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#547665: RFP: valide -- IDE for Vala



Le 20/09/2010 09:15, David Paleino a écrit :
> If you're still interested, I'm available to review and sponsor it.
>
>   
Thank you!
>> It's available on debian mentors:
>> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=valide
>>
>> Should you require any additional information, please do not hesitate to
>> contact me.
>>     
> Here are my comments on the packaging:
>
>  - before seeing this bug, I downloaded the tarball from your website. Why is
>    the one on the website 24M, and the one on mentors just 1.4M ?
>  - debian/changelog: this package has never been released to Debian, so you
>    should only have one stanza, with "Initial upload (Closes: #547665)"
>  - debian/control:
>    - Build-Depends: you're missing at least valac as dependency here. I haven't
>      checked further.
>    - Standards-Version: latest is 3.9.1, please update it
>    - Vcs-* missing: if you're maintaining the debian/ directory under some VCS,
>      please point to it using Vcs-Browser and Vcs-Svn (or Vcs-Git, Vcs-Bzr,
>      [..]).
>    - hardcoding runtime dependencies on shared libraries is bad. It doesn't
>      let binNMUs. If ${shlibs:Depends} doesn't work, something's wrong, and
>      should be fixed.
>    - you're duplicating "Section: devel" in valide-common and valide-dev
>    - long descriptions are a bit too "short" :)
>   
I find inspiration and I try to improve this.
>    - valide-dev should depend on valide (= ${binary:Version})
>    - debian/copyright: you could choose to follow DEP-5, but that's entirely
>      optional.
>    - why do you have debian/patches/debian-changes-0.7.0-1? Please merge those
>      changes upstream, and rebuild the package with a fixed orig.tar.gz
>    - debian/valide*.install: you can just drop debian/tmp/ from there :)
>    - debian/valide.lintian: should be named valide.lintian-overrides. After
>      that, you can drop valide.dirs, and the hack in debian/rules to install
>      this file.
>   
I renamed the lintian file, but I don't know how to hack debian/rules.
>    - debian/rules: why are you using that CMD=$(..) thing? You're using it only
>      once, and I don't see any benefit in it :)
>
>
> Please let me know whether you still intend to maintain it, and eventually fix
> the above comments.
>
>   
Except my comments, I fixed the other problems in the upsteam
repository: https://code.launchpad.net/~valide/valide/trunk

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: