On Sat, Jan 09, 2010 at 10:31:05AM +1300, martin f krafft wrote:
> David and I agreed to take your work as the basis for the Debian
> collab-maint repository, so I cloned it to
> ssh://git.debian.org/git/collab-maint/notmuch.git, but I renamed the
> debian branch to master.
Hey, Martin. That's great! I'm very glad this packaging work is
useful.
I was just about to respond to your previous comment when I got this.
I'm happy to help with the maintaining. My only hesitation is that my
C skills are very weak, and I'm only now starting to get the hang of
elisp. If others are willing to help vet patches (which I don't think
will be a real problem, seeing as Carl is very receptive and is a DD
himself), then I'm definitely willing help handle the Debian
packaging.
We should really also consult with Carl, since he did express interest
in maintaining the package himself:
http://notmuchmail.org/pipermail/notmuch/2009/000740.html
I'm certainly willing to help in any way I can, though.
> 1. There are changes outside of debian:
>
> lapse:…kg/notmuch/notmuch|master|% git diff origin/{upstream,master} | diffstat
> Makefile.local | 4 +--
> configure | 6 -----
>
> Can these go upstream? If they have to be Debian-specific, then
> I suggest that we put them into a topic branch and generate a quilt
> series from that. TopGit can help doing that.
I was actually going to try to push these changes upstream when I got
a chance. I really don't see why there should be any Debian specific
patches at this point.
> 2. There is a build dependency missing on emacs.
You're right. I'll fix that. I'm still getting used to all the
packaging emacs support stuff.
> 3. The version numbering (0.0-1) is not optimal. I suggest to use
> a timestamp for now (0.0.201001091018-1) and then to switch to
> a git-ref-based approach once there's the first tag (using git
> describe, e.g. 0.1-16-g4989ef3-1).
Yeah, I didn't know what to use there. I think your suggestion sounds
fine.
> 4. debian/control: Vcs-Git should be changed to the above
> git.debian.org URL, and you can add Vcs-Browser: Vcs-Git:
> http://git.debian.org/?p=collab-maint/notmuch.git;a=summary
Great.
> 5. I don't think notmuch should recommend emacs. The Enhances is
> correct though. If you think that it should go the other way too,
> then please limit yourself to a Suggest.
Ok, that's reasonable.
> 6. Probably add vim to Enhances too.
So I don't believe that any of the vim stuff is included in the
package. I know nothing about vim support, so if someone (you?) wants
to get all the vim support in place in the package that would be
great.
> 7. debian/copyright puts all of debian/* under the GPL-3+ and does
> not make a distinction between copyright holders. That's not
> a problem, just making sure that this is what you want.
I wasn't sure what to do about the copyright, so I just took everyone
who committed to upstream. I figured we would address it when
packaging actually started to move forward. I did mean to put
debian/* under GPL-3+, but I'm open to any other suggestions about how
it should copyrighted.
> 8. debian/dirs, you don't need the /usr/share lines. dh_installman
> creates them.
Ok, thanks. I didn't realize that. I'll make that change as well.
> 9. The changelog entry should close the ITP bug.
I was waiting to see what was actually going to happen with this stuff
to add that, but I'll go ahead and add it to get rid of the lintian
warning.
I finally made myself an alioth account, but it still hasn't processed
my ssh key. As soon as I can get in, I'll push the changes.
jamie.
Attachment:
signature.asc
Description: Digital signature