also sprach Jameson Rollins <jrollins@finestructure.net> [2010.01.07.0647 +1300]:
> Hi, folks. I have been maintaining a git debian branch that uses
> git-buildpackage and builds lintian clean:
>
> git://lair.fifthhorseman.net/~jrollins/notmuch
Jameson,
David and I agreed to take your work as the basis for the Debian
collab-maint repository, so I cloned it to
ssh://git.debian.org/git/collab-maint/notmuch.git, but I renamed the
debian branch to master.
I have a few comments:
1. There are changes outside of debian:
lapse:…kg/notmuch/notmuch|master|% git diff origin/{upstream,master} | diffstat
Makefile.local | 4 +--
configure | 6 -----
Can these go upstream? If they have to be Debian-specific, then
I suggest that we put them into a topic branch and generate a quilt
series from that. TopGit can help doing that.
2. There is a build dependency missing on emacs.
3. The version numbering (0.0-1) is not optimal. I suggest to use
a timestamp for now (0.0.201001091018-1) and then to switch to
a git-ref-based approach once there's the first tag (using git
describe, e.g. 0.1-16-g4989ef3-1).
4. debian/control: Vcs-Git should be changed to the above
git.debian.org URL, and you can add Vcs-Browser: Vcs-Git:
http://git.debian.org/?p=collab-maint/notmuch.git;a=summary
5. I don't think notmuch should recommend emacs. The Enhances is
correct though. If you think that it should go the other way too,
then please limit yourself to a Suggest.
6. Probably add vim to Enhances too.
7. debian/copyright puts all of debian/* under the GPL-3+ and does
not make a distinction between copyright holders. That's not
a problem, just making sure that this is what you want.
8. debian/dirs, you don't need the /usr/share lines. dh_installman
creates them.
9. The changelog entry should close the ITP bug.
Thanks for your good work,
--
.''`. martin f. krafft <madduck@d.o> Related projects:
: :' : proud Debian developer http://debiansystem.info
`. `'` http://people.debian.org/~madduck http://vcs-pkg.org
`- Debian - when you have better things to do than fixing systems
Attachment:
digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/)