[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [pkg-wine-party] Rules-Requires-Root setting (was: wine-development_3.3-1_source.changes ACCEPTED into unstable)



On 19.05.2018 11:13, Michael Gilbert wrote:
> On Sat, May 19, 2018 at 4:45 AM, Jens Reyer wrote:
>> How exactly do you invoke this?  I tried this (in the git repo):
>>
>> $ ./debian/rules binary
>> [...]
>> make -C tools/sfnt2fon
>> make[2]: Entering directory
>> '/home/jens/development/wine/wine/wine/tools/sfnt2fon'
>> gcc -m64 -c -o sfnt2fon.o sfnt2fon.c -I. -I../../include
>> -I/usr/include/freetype2 -I/usr/include/libpng16 \
>>   -D__WINESRC__ -Wall -pipe -fno-strict-aliasing
>> -Wdeclaration-after-statement -Wempty-body \
>>   -Wignored-qualifiers -Wshift-overflow=2 -Wstrict-prototypes
>> -Wtype-limits \
>>   -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith
>> -Wlogical-op -gdwarf-2 \
>>   -gstrict-dwarf -Werror -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
>> -fdebug-prefix-map=/home/jens/development/wine/wine/wine=.
>> -fstack-protector-strong -Wformat -Werror=format-security -Wno-error
>> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
>> gcc -m64 -o sfnt2fon sfnt2fon.o -lwine_port -lfreetype -Wl,-z,relro
>> -Wl,-z,now -Wl,-rpath,/usr/lib/x86_64-linux-gnu/wine
>> /usr/bin/ld: cannot find -lwine_port
>> collect2: error: ld returned 1 exit status
>> Makefile:185: recipe for target 'sfnt2fon' failed
>> make[2]: *** [sfnt2fon] Error 1
>> make[2]: Leaving directory
>> '/home/jens/development/wine/wine/wine/tools/sfnt2fon'
>> debian/rules:122: recipe for target 'override_dh_auto_build-indep' failed
>> make[1]: *** [override_dh_auto_build-indep] Error 2
>> make[1]: Leaving directory '/home/jens/development/wine/wine/wine'
>> debian/rules:107: recipe for target 'binary' failed
>> make: *** [binary] Error 2
> 
> You may not have patches applied?  sfnt2fon.patch should fix those errors.

D'oh, yes.

>> On the other side (afair) I successfully tried "debuild" when I added
>> "RRR: no" the first time.  So my conclusion was "./debian/rules binary"
>> on its own is not a valid invocation, and "RRR: no" is correct.
> 
> debuild automatically calls fakeroot when its needed.

Turns out the specification changed a bit, but wasn't documented yet,
see #899125.  For manual testing you have to set and export
DEB_RULES_REQUIRES_ROOT=no

$ export DEB_RULES_REQUIRES_ROOT=no
$ quilt push -a
$ ./debian/rules binary
[...]
   dh_builddeb
	dpkg-deb --root-owner-group --build debian/wine ..
dpkg-deb: building package 'wine' in '../wine_3.0.1-1_all.deb'.
	dpkg-deb --root-owner-group --build debian/wine64 ..
[...]

So we can set "no" in rules.

Greets
jre


Reply to: