[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [pkg-wine-party] Rules-Requires-Root setting (was: wine-development_3.3-1_source.changes ACCEPTED into unstable)



Hi Mike,

On 19.05.2018 10:14, Michael Gilbert wrote:
> On Sat, Apr 7, 2018 at 6:14 PM, Jens Reyer wrote:
>>>    * Correctly specify that root is required to execute debian/rules binary.
>>
>> Can you tell me why root is required here?
> As stated there in the changelog message, it is required to be able to
> execute "./debian/rules binary" without invoking fakeroot.
> 
> If you try it without fakeroot, you will get this error currently:
> 
> dh_testroot: You must run this as root (or use fakeroot).
> 
> Why debhelper adds dh_testroot lines for wine's binary targets, I'm
> not sure. I haven't looked into it yet, but that must be fixed first
> to be able to correctly set RRR:no for the packages.

How exactly do you invoke this?  I tried this (in the git repo):

$ ./debian/rules binary
[...]
make -C tools/sfnt2fon
make[2]: Entering directory
'/home/jens/development/wine/wine/wine/tools/sfnt2fon'
gcc -m64 -c -o sfnt2fon.o sfnt2fon.c -I. -I../../include
-I/usr/include/freetype2 -I/usr/include/libpng16 \
  -D__WINESRC__ -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement -Wempty-body \
  -Wignored-qualifiers -Wshift-overflow=2 -Wstrict-prototypes
-Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith
-Wlogical-op -gdwarf-2 \
  -gstrict-dwarf -Werror -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/home/jens/development/wine/wine/wine=.
-fstack-protector-strong -Wformat -Werror=format-security -Wno-error
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
gcc -m64 -o sfnt2fon sfnt2fon.o -lwine_port -lfreetype -Wl,-z,relro
-Wl,-z,now -Wl,-rpath,/usr/lib/x86_64-linux-gnu/wine
/usr/bin/ld: cannot find -lwine_port
collect2: error: ld returned 1 exit status
Makefile:185: recipe for target 'sfnt2fon' failed
make[2]: *** [sfnt2fon] Error 1
make[2]: Leaving directory
'/home/jens/development/wine/wine/wine/tools/sfnt2fon'
debian/rules:122: recipe for target 'override_dh_auto_build-indep' failed
make[1]: *** [override_dh_auto_build-indep] Error 2
make[1]: Leaving directory '/home/jens/development/wine/wine/wine'
debian/rules:107: recipe for target 'binary' failed
make: *** [binary] Error 2

On the other side (afair) I successfully tried "debuild" when I added
"RRR: no" the first time.  So my conclusion was "./debian/rules binary"
on its own is not a valid invocation, and "RRR: no" is correct.  I'll
give it some deeper look (your answer to the above question would help a
lot), and try to find some person familiar with RRR here at DebConf.

Thanks a lot to your answer, and the khronos-api upload.  I'll prepare a
src:wine upload soon.  I take it you're taking src:wine-development 3.8?


> By the way, thank you for getting the new mailing list set up.

Yay :)

Greets
jre


Reply to: