[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Raphael Hertzog: When to commit into repositories of teams?

On Mon, 10 Mar 2008, Andreas Barth wrote:
> * Raphael Hertzog (hertzog@debian.org) [080310 09:46]:
> > On Mon, 10 Mar 2008, Andreas Barth wrote:
> > > * Adeodato Simó (dato@net.com.org.es) [080309 22:05]:
> > > > #436093 for those following along at home.
> > > 
> > > It could be dpkg as well.
> > 
> > Can you justify this assertion? 
> > 
> > I have worked _with_ Guillem Jover and Frank Lichtenheld and _they_ have
> > granted me commit rights to the repository.
> Where in my message did I say "buxy has done commits of that kind, and
> he should explain his actions"? I just asked them what your opinion is,
> and the recent dpkg flame fest gave me the idea to ask.

The subject of your mail is "When to commit into repositories of teams?"
and you thus imply that I have commited without authorization in the dpkg
team repository. That's simply not correct.

> In that case, you obviously were involved, as you e.g. asked for
> unaccepts of dpkg, and reverted the commits of Ian to the git
> repository.

I didn't revert anything. Ian only committed in seperate branches.

The unaccept has been requested by Guillem and I simply pinged ftpmasters
on IRC and communicated the status of the situation to -devel.

> So, perhaps you can give me a summary why e.g. Ians commits to dpkg
> wasn't ok, even though he was trying to get his patches integrated for 6
> months, but your commits to dev-ref were ok, even though you didn't
> contact me (or opened a bug report) and it is explicitly documented you
> shouldn't just commit?

I wasn't aware of the new review rule and you didn't explain it to me. I
said that I will happily provide patches instead to let other people
comment in the future. My commits were not ok but you failed to explain me
why. And I didn't want to replace you and I'm always ready to work with you.

In Ian's case, he was aware before the commit that we didn't want him to
do the merge and despite the guidance that I tried to provide him, he
stubbornly was blocked to the unconditional merge of his branch as is
(that is with a messed up history). Ian hasn't accepted any compromise and
hijacked the package and clearly showed that he doesn't want to work
with Guillem.

I hope you see the difference.

Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :

Reply to: