Re: Bug#21412: tob deletes system files

[Agustin Martin Domingo <agmartin@aq.upm.es>]

Dirk Eddelbuettel wrote:
> 
> 
> Please chill out a little and read the emails you got yesterday.  I released
> tob_0.14-5 yesterday which added the following test
> 
>         cleanup ()
>         {
>             message 'Cleaning up.'
>             # add a safety check here   --edd 20 Apr 98, regarding #21412
> ----->      if [ "$TMPLIST" != "" -a "$FILELIST" != "" ] ; then
>                 $RM -f $TMPLIST* $FILELIST*
>             fi
>             postcommand
>         }
> 
> 

Just one minor comment, $TMPLIST and $FILELIST void means problems in
/etc/tob/tob.rc, that can be caused by an incorrect local adaptation.
May be it would worth to add a warning message to the if, and even exit
tob if that situation is found (perhaps this last be too drastical),
something like


         cleanup ()
         {
             message 'Cleaning up.'
             # add a safety check here   --edd 20 Apr 98, regarding
#21412
             if [ "$TMPLIST" != "" -a "$FILELIST" != "" ] ; then
                 $RM -f $TMPLIST* $FILELIST*
             else
                  message 'Warning: Empty \$TMPLIST or \$FILELIST. Check
your /etc/tob/tob.rc'
                  # exit # In this case change above line to error:
             fi
             postcommand
         }

Regards,

-- 
=====================================================================
Agustín Martín Domingo, Dpto. de Física, ETS Arquitectura Madrid, 
(U. Politécnica de Madrid)  tel: +34 +1 3366536, Fax: +34 +1 3366554, 
email:agmartin@aq.upm.es, http://corbu.aq.upm.es/~agmartin/welcome.html


--
To UNSUBSCRIBE, email to debian-user-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org