[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please review alsaconf patch

On Wed, Nov 02, 2005 at 09:54:59PM +0100, Roland Stigge wrote:
> Martin Habets wrote:
> >>(1) $PROCFS was not defined, so I set it manually. I didn't know where
> >>you intended it to come from so I just set it in the beginning of the
> >>patch to /proc.
> > 
> > It is set at line 30 of the script. Maybe you are using an old version of
> > alsconf?
> The one from unstable, and indeed the experimental version sets $PROCFS.
> But that shouldn't make a difference for the other points. I need to
> stick with unstable; for my taste, it's unstable enough. ;)

Ok, that explains. I created the patch against ALSA 1.0.10rc1, as it will
go into ALSA CVS. From there it will be picked up by all distro's.
So it will be a while before this hits debian stable :)

> >>(2) I guess you meant mounting openpromfs in case /proc/openprom exists?
> >>Therefore && instead of ||.
> > 
> > I meant to mount it if it has not been mounted yet. Fixed the code for this.
> Wouldn't it even better if we leave the system in the state we found it?
> I.e. unmounting in the end if mounting in the beginning.

Yes that would be better, but I consider that a bit overkill.


Reply to: