[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please review alsaconf patch

To be honest, I just copied that line from the powermac code.
Wrong move it seems. I'll replace it with find as suggested.


On Mon, Oct 31, 2005 at 02:43:57PM +0100, Frans Pop wrote:
> On Monday 31 October 2005 14:11, Martin Habets wrote:
> > +	/sbin/modprobe -a -l | grep 'snd-sun-' | \
> Hmmm. Is "-a -l" correct for modprobe? -l is supposed to list modules, -a 
> to insert (load) them...
> I doubt that the intention here is to try to actually load all modules 
> available on the system, so why "-a"? Or am I missing something?
> From the manpage, -l takes a wildcard, thus why not just use
>   modprobe -l snd-sun-*
> ?
> Also from the manpage it looks like both the -a and the -l options are 
> deprecated and using something like
>   find /lib/modules/$(uname -r)/kernel/ -name "snd-sun-*"
> is suggested instead.
> Cheers,

Reply to: