Re: ALSA Driver for Sparc DBRI chips
At Fri, 15 Apr 2005 00:33:41 +0100,
Martin Habets wrote:
>
> On Wed, Apr 13, 2005 at 07:41:27PM +0200, Hendrik Sattler wrote:
> > There is still the problem, that linux/modversions.h is not included in any of
> > the sparc drivers.
>
> I've been able to reproduce this problem. Seems to be a case where less is
> more. Please find a patch attached.
>
> Takashi, can you please apply the patch attached?
Thanks, applied to ALSA CVS tree.
> David, it looks like similar patches are needed for the other ALSA sparc
> drivers. Do you agree with this?
Well, this is basically the failure in alsa-driver's build for 2.2/2.4
kernels. It should add -include xxx/modversions.h to CFLAGS. I'll
fix it now.
> > > > Is the dbri driver going to be submitted to official ALSA?
> > >
> > > The driver is in ALSA 1.0.8 (part of alsa-driver). I don't expect ALSA
> > > 1.0.8 to ever be pulled back into the 2.4 kernels, but I could be wrong.
> >
> > That's strange, I have the alsa-source-1.0.8-7 debian package installed and
> > there is not dbri.c, neither does upstream alsa-driver-1.0.9rc2. It's also
> > not at http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-kernel/sparc/
> > There's no problem in adding the files, though.
>
> The driver is not (yet) in alsa-kernel. In alsa-source-1.0.8-7 debian package
> you'll find it in modules/alsa-driver/sparc/dbri.c. ALSA CVS has it in
> http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-driver/sparc/
It's fine to me to move this driver to alsa-kernel tree as long as
someone can confirm that it's working on 2.6 kernels. Anyone?
Takashi
Reply to: