Re: ALSA Driver for Sparc DBRI chips
On Wed, Apr 13, 2005 at 07:41:27PM +0200, Hendrik Sattler wrote:
> There is still the problem, that linux/modversions.h is not included in any of
> the sparc drivers.
I've been able to reproduce this problem. Seems to be a case where less is
more. Please find a patch attached.
Takashi, can you please apply the patch attached?
David, it looks like similar patches are needed for the other ALSA sparc
drivers. Do you agree with this?
> > > Is the dbri driver going to be submitted to official ALSA?
> >
> > The driver is in ALSA 1.0.8 (part of alsa-driver). I don't expect ALSA
> > 1.0.8 to ever be pulled back into the 2.4 kernels, but I could be wrong.
>
> That's strange, I have the alsa-source-1.0.8-7 debian package installed and
> there is not dbri.c, neither does upstream alsa-driver-1.0.9rc2. It's also
> not at http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-kernel/sparc/
> There's no problem in adding the files, though.
The driver is not (yet) in alsa-kernel. In alsa-source-1.0.8-7 debian package
you'll find it in modules/alsa-driver/sparc/dbri.c. ALSA CVS has it in
http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-driver/sparc/
> > Regarding your email address: I'll be in Karlsruhe next week for the
> > LAC (http://lac.zkm.de/). Will you by any chance attend that too?
>
> No, I probably won't have time for that. However, if you need some old sparc32
> equipment, I have some spare parts (for free :)
Can always use stuff with different sound chips in it. But don't want to
start a museum :)
Thanks for your continued testing. I appreciate the feedback.
Regards,
--
Martin
---------------------------------------------------------------------------
The dbri driver fails to compile when CONFIG_MODVERSIONS is set. This patch
fixes that problem.
Signed-off-by: Martin Habets <errandir_news@mph.eclipse.co.uk>
--- alsa-driver-1.0.8-7/sparc/dbri.c.orig 2005-04-14 23:52:52.000000000 +0100
+++ alsa-driver-1.0.8-7/sparc/dbri.c 2005-04-15 00:07:30.000000000 +0100
@@ -45,13 +45,10 @@
* connected.
*/
-#include <linux/module.h>
-#include <linux/kernel.h>
+#include <sound/driver.h>
#include <linux/interrupt.h>
-#include <linux/slab.h>
#include <linux/delay.h>
-#include <sound/driver.h>
#include <sound/core.h>
#include <sound/pcm.h>
#include <sound/pcm_params.h>
Reply to: