[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: arno-iptables-firewall/2.0.3-1 [ITA]



Hello,

1. I've found that version 2.0.1.f was released at rocky.eld.leidenuniv.nl [1], and later was imported into github.
Although GitHub has autogenerated a tarball for the tag 2.0.1f, its release notes has the url [1] of the correct tarball.
The pristine-tar tarball checksum match the checksum of this official release:
af32d7757a3e85a7b92b88c8e4dfdfd86bb32b16  arno-iptables-firewall_2.0.1.f.orig.tar.gz
af32d7757a3e85a7b92b88c8e4dfdfd86bb32b16  arno-iptables-firewall_2.0.1f.tar.gz

2. I've succeeded to run autopkgtest with 'null' virtual-server inside a VirtualBox VM (not a minimal installation):
$ sudo autopkgtest arno-iptables-firewall_2.0.3-1_amd64.changes -- null

All tests pass. The service installed by the package blocks incoming ssh connection, so testing via 'ssh' testbed isn't possible leaving us with choice only of 'qemu' and 'null' virtual servers.

So the list of the reviewed items now is:
[x] checksums of all two pristine-tar tarballs match checksums the related upstream releases
[x] autopkgtest: all tests pass (with a virt-server=null)
[x] arno-iptables-firewall_2.0.3-1.dsc builds cleanly with pbuilder
[x] the package correctly builds twice by debuild within the source tree

and
> [x] checked d/watch with uscan - works as expected, although it's unusual to see uupdate running from d/watch.
> [x] fr.po and sv.po are correctly converted to uft8
> [x] d/control looks sane
> [x] new d/arno-iptables-firewall.logrotate looks good



  Best wishes,
  Aleksey


On Wed, Jan 9, 2019 at 6:17 PM Aleksey Kravchenko <rhash.admin@gmail.com> wrote:
Hello team,

I've reviewed a bit more:
[x] arno-iptables-firewall_2.0.3-1.dsc builds cleanly with pbuilder
[x] the package correctly builds twice by debuild within the source tree

I found strange thing. The content match, but checksum doesn't match for the previous release tarball:
$ pristine-tar checkout arno-iptables-firewall_2.0.1.f.orig.tar.gz
$ sha1sum arno-iptables-firewall_2.0.1.f.orig.tar.gz aif-2.0.1f.tar.gz
af32d7757a3e85a7b92b88c8e4dfdfd86bb32b16  arno-iptables-firewall_2.0.1.f.orig.tar.gz
a18f94fb9324df8e8e4a28805b92269ff8bd1bc6  aif-2.0.1f.tar.gz
, where 
aif-2.0.1f.tar.gz is taken from upstream github tag [1]

I'm experiencing some problems running autopkgtest:

1) failed to correctly setup serial console ttyS0/ttyS1 for qemu debian-sid image (autopkgtest fails to connect)

2) autopkgtest fails with ssh to a VirtualBox VM, using command:
autopkgtest arno-iptables-firewall_2.0.3-1_amd64.changes -- ssh --capability=isolation-machine -l root -p 2022 -H 127.0.0.1

See the log [2]. It looks like autopkgtest doesn't not install arno-iptables-firewall_2.0.3-1_all.deb
To run the test I've also removed the 'needs-root' restriction, since the option '--capability=root-on-testbed' is not enough.



On Wed, Jan 9, 2019 at 1:02 AM Sven Geuer <debmaint@g-e-u-e-r.de> wrote:
Hi Samuel,

I removed pre-squeeze upgrade code

Regarding your change 'Bump DH level to 12' I believe debian/control
needs further changes.

The debhelper manpage says:

Changes from v11 are:
        [...]
        This change makes dh_installinit inject a misc:Pre-Depends
        for init-system-helpers (>= 1.54~).  Please ensure that the
        package lists ${misc:Pre-Depends} in its Pre-Depends field
        before upgrading to compat 12.
        [...]

Please double-check.

Best,
Sven


Reply to: