Re: [review] ledger-udev

[Stéphane Neveu <stefneveu@gmail.com>]

Hi Raphaël,

>
> Let's see what I can find.
>
> First I find the name very disturbing. Wouldn't ledger-wallets-udev be a
> better fit ?
>

Sure, I've renamed everything (I hope) except the git directory
directly on salsa because I cannot ssh on salsa anymore :/ I'm not
sure what happened.

> debian/ledger-udev.7.ronn mentions /etc/udev/rules.d/20-ledger.rules when
> in fact it's /lib/udev/rules.d/20-ledger.rules (overridable by the user
> in /etc/udev/rules.d/20-ledger.rules).
>
> debian/control says ledger-udev is "Architecture: any" but really I don't
> see anything architecture specific, I believe it can be "Architecture:
> all". Or did I miss something here?
>
> I would rewrite the description to put the specific models in the long
> description and have a generic term in the short description:
>
> Description: udev rules for Ledger hardware wallets
>  This package provides udev rules for the following models
>  of hardware wallets:
>  .
>   * Ledger Nano S
>   * Ledger Blue

I hope this looks better now.

Thank you,
Cheers,
Stéphane