Re: RFS: openmx/3.8.4
Uploaded. Thanks for contribution!
Anton
2018-05-13 20:14 GMT+02:00 Innocent De Marchi <tangram.peces@gmail.com>:
> El Sat, 12 May 2018 22:19:39 +0200
> Hi Anton,
>
>>
>> 1) uscan downloads patch3.8.4.tar.gz which differs for the tarball,
>> uploaded into the git. Is it possible to update d/watch to
>> download the used tarball?
>
> Uscan download the patch and get-orig-source.sh download the source
> tar.gz file, unpack the two and make the compressed .orig file. This
> worked like that since 2013.
> Maybe it's a little complex system!
>
>>
>> 2) If you repack the archive (I see you removed some so-files), please
>> add +dfsg1 prefix to the upstream version number.
>
> Done.
>
>>
>> 3) From my POV, if you patch some sources, it is not neccessary to
>> leave the original code commenting it. Just make a fix, so the patch
>> will be more readable. But it is up to you.
>
> Done.
>
>>
>> 4) I think debian/dirs is not needed in this case.
>>
>
> Yes it's correct! Done.
>
>> I did not compile this package. Please be sure to fix all lintian
>> warnings and errors, if they are there. Also it would be good to go
>> through d/copyright and check, whether all files are covered by it.
>>
>
> It seems that everything is correct. The copyright of the
> source/elpa1.f90
> file is unclear: it seems that these are this
> http://elpa.mpcdf.mpg.de/software
>
> Regarding lintian, these are the current messages:
> I: openmx source: testsuite-autopkgtest-missing
> I: openmx source: debian-watch-uses-insecure-uri
> http://www.openmx-square.org/download.html
> W: openmx source:
> debian-watch-file-should-mangle-version line 3
> P: openmx source:
> debian-watch-does-not-check-gpg-signature P: openmx-data:
> no-upstream-changelog
> I: openmx: spelling-error-in-binary
> usr/bin/openmx Outputing Outputting
> I: openmx: spelling-error-in-binary
> usr/bin/openmx directry directory
> I: openmx: spelling-error-in-binary
> usr/bin/openmx openning opening
> I: openmx: spelling-error-in-binary
> usr/bin/openmx lenght length
> I: openmx: spelling-error-in-binary
> usr/bin/openmx Intial Initial
> I: openmx: spelling-error-in-binary
> usr/bin/openmx transmition transmission
> P: openmx: no-upstream-changelog
>
> The error does not affect since with the watch file it download the
> patch file that does not have +dfsg1 (could be put in
> lintian-overrides).
> The other messages must be solved by the upstream.
>
>> Please let me know when you fix those issues, I will upload the
>> package.
>
> I hope everything's correct!
>
> Thanks for your help.
>
> I. De Marchi
>
Reply to: