Re: RFS: openmx/3.8.4
Hi,
some notes:
1) uscan downloads patch3.8.4.tar.gz which differs for the tarball,
uploaded into the git. Is it possible to update d/watch to download
the used tarball?
2) If you repack the archive (I see you removed some so-files), please
add +dfsg1 prefix to the upstream version number.
3) From my POV, if you patch some sources, it is not neccessary to leave
the original code commenting it. Just make a fix, so the patch will be
more readable. But it is up to you.
4) I think debian/dirs is not needed in this case.
I did not compile this package. Please be sure to fix all lintian warnings
and errors, if they are there. Also it would be good to go through
d/copyright and check, whether all files are covered by it.
Please let me know when you fix those issues, I will upload the package.
Nice work!
Best regards
Anton
2018-05-06 18:44 GMT+02:00 Innocent De Marchi <tangram.peces@gmail.com>:
> Hi,
>
> I have updated the openmx [0] package to the new version of the
> upstream.
> It seems that Christophe Prud'homme is not more active [1].
>
> The new version of the package has several changes: here is the
> changelog:
>
> * New upstream version (Closes: #812716).
> * Team upload.
> * Standards-Version: 4.1.4.
> * Updated uploaders field (Closes: #835017, #706711).
> * Write vcs field on canonical format (debian/control).
> * Write secure copyright format uri on d/copyright.
> * Updated years on d/copyright.
> * Added hardening flags on d/rules.
> * Removed empty d/docs file.
> * Added Multi-Arch field on d/control.
> * Adapted the makefile.patch patch to new sources.
> * Three New patches to fix an error in the compilation (*_test.patch).
> * Removed unnecessary files from sources (with get-orig-source.sh).
>
> I have updated the package in the salsa [2] repository, without adding
> the tag of the new version waiting for the revision (and possible
> changes) and upload of the new package.
>
> Regards!
>
> I. De Marchi
>
> [0] https://tracker.debian.org/pkg/openmx
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=706711
> [2] https://salsa.debian.org/science-team/openmx
>
Reply to: