Re: Sponsor upload request for new package scram
> On 17 Nov 2016, at 20:00, Olzhas Rakhimov <ol.rakhimov@gmail.com> wrote:
>
> Hello James,
> Thanks for the prompt feedback. I reuploaded a revised version.
>
>> On Thu, Nov 17, 2016 at 11:24 AM, James Clarke <jrtc27@jrtc27.com> wrote:
>> Hi Olzhas,
>>> On 17 Nov 2016, at 18:48, Olzhas Rakhimov <ol.rakhimov@gmail.com> wrote:
>>>
>>> Hello everybody,
>>> I uploaded a new version with the repository on alioth.
>>> I would like to hear your feedback.
>>
>> 2. Until you’re ready to upload, leave the distribution as UNRELEASED.
>> `dch` (and `dch -r` to release) should do this automatically, but
>> you’ll need to change it manually since the entry already exists
>> (I think).
You still haven’t done this. Moreover, please stop changing the version
number on every commit. 0.11.4-1 should be the first version you upload,
and you should not tag it in git until you upload it. Please delete the
debian/0.11.4-3 and -4 tags (and make sure to delete them on the remote
too, not just locally), and don’t create any tags until you get the go-
ahead from a sponsor. Note that if you upload to mentors.debian.net, you
can keep uploading modified packages with the same -1 version.
>> 3. Bump d/compat up to 10; debhelper 10 is available in backports.
>
> It looks like Ubuntu 16.04 still has 9.2, so I am getting warnings from lintian.
Indeed, xenial-backports has debhelper 10, but no updated lintian. Just
ignore any warnings about that. You do, however, need to make sure you
have the right versioned depends on debhelper (>= 10) (10 not 10.0.0).
>> 6. Does Release include debugging information? I thought there was
>> RelWithDebInfo or something similar for that? Please make sure
>> debugging information is included; dh_strip will strip it from the
>> package and create an automatic scram-dbgsym for it (which should
>> not be mentioned in d/control), so there are debugging symbols for
>> those who want it, but no increase in size for those who don’t.
>
> The global flags are running with RelWithDebInfo : -O2 -g.
> Release just adds -O3 at the end.
You’re right, -O2 -g is given, but not because of anything to do with
RelWithDebInfo. They’re coming from the default CFLAGS for Debian
packages, along with `-fdebug-prefix-map=<dir> -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2`, some
of which are hardening flags.
8. There’s a typo in doc/scram.man: Calcualte should be Calculate. Note
that I got this from `lintian -EI --pedantic`. This can be verbose,
but I suggest you get in the habit of checking it, since it can pick
up on things you might otherwise miss.
9. When building, I get the following:
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/scram/usr/bin/scram was not linked against libglib-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/scram/usr/bin/scram was not linked against libsigc-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/scram/usr/bin/scram was not linked against libboost_date_time.so.1.62.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/scram/usr/bin/scram was not linked against libxml2.so.2 (it uses none of the library's symbols)
Given this is the only binary artefact, why are these libraries being
given in LDFLAGS?
Regards,
James
Reply to: