[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#704782: trilinos: new package for Trilinos 11.x



> outdated-autotools-helper-file - this should be easily fixed with
> autoreconf [1], i.e. simply changing to:

These autotools files aren't used for building anymore, and I have had them removed from upstream entirely -- almost. For some reason, the Zoltan devs wanted to keep them. I'd say we ignore those warnings.

dep5-copyright-license-name-not-unique and
space-in-std-shortname-in-dep5-copyright - should be easy to fix, e.g.
'gpl-2 w/bison exception' can be changed to 'GPL-2.0-with-bison-exception'.

I'll handle this.

In debian/control you are restricting the architecture to amd64.
I'd prefer 'Architecture: any', at least for the initial upload, and
take it from there.  Trilinos might be useful on ppc64el, for example.

amd64 is the only arch officially supported by Trilinos, but indeed we might get lucky with others, too. We already know that kokkos doesn't compile on 32bit (x86) machines though.

--Nico

On Wed, Sep 23, 2015 at 2:34 PM Graham Inggs <ginggs@debian.org> wrote:
On 23/09/2015 09:52, Felix Salfelder wrote:
> building binary packages from master-{11,12} now works for me, can
> anybody reproduce?

I have just successfully built trilinos from master-12. :)
Thanks Nico and Felix for your efforts!


A couple of Lintian warnings:

outdated-autotools-helper-file - this should be easily fixed with
autoreconf [1], i.e. simply changing to:

        dh $@ --with autoreconf

dep5-copyright-license-name-not-unique and
space-in-std-shortname-in-dep5-copyright - should be easy to fix, e.g.
'gpl-2 w/bison exception' can be changed to 'GPL-2.0-with-bison-exception'.


Some comments of my own:

In debian/rules you seem to have a mix of short form dh and debhelper.
The install-stamp and configure-stamp stuff can probably go.

In debian/control you are restricting the architecture to amd64.
I'd prefer 'Architecture: any', at least for the initial upload, and
take it from there.  Trilinos might be useful on ppc64el, for example.


[1] https://wiki.debian.org/Autoreconf


Reply to: