[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: examples of gtest done right in Debian



Hi Ghislain:

On 08/05/2015 01:30 PM, Ghislain Vaillant wrote:
> Hi Anton,
> 
> That sounds like a good example, although not exactly what I had in mind.
> 
> Please correct me if I am wrong but I am assuming from this patch that
> gazebo was compiling gtest from a vendorized copy? 

Right.

> The patch then
> consists in pointing gazebo to a different location for the gtest source
> files. So, gazebo was already following the upstream gtest
> recommendations, which made patching for Debian quite simple.

Right.

> The upstream projects I am dealing with rely on the fact that a
> pre-compiled version already exists in the system and the latter is
> detectable via find_package. For this, I expect (perhaps wrongfully)
> patching to be much more invasive.

I agree with your analysis. You probably will need to patch and compile
gtest together with your software.

> Hence myself asking whether such case has already been dealt with in the
> archive, so I don't spend too much time trying things.

I don't know about any helper provided by debian packaging utilities to
avoid every maintainer the task of creating the commands to compile and
use gtest with your building system.

> Thanks,
> Ghis
> 
> 
> On 05/08/15 10:15, Anton Gladky wrote:
>> Hi Ghislain,
>>
>> gazebo was fixed recently to use a system-installed
>> gtest [1].
>>
>> [1]
>> http://anonscm.debian.org/cgit/debian-science/packages/gazebo.git/tree/debian/patches/0002_use_system_gtest.patch
>>
>>
>> Cheers
>>
>>
>> Anton
>>
>> 2015-08-05 11:12 GMT+02:00 Ghislain Vaillant <ghisvail@gmail.com
>> <mailto:ghisvail@gmail.com>>:
>>
>>     Hi everyone,
>>
>>     I am currently dealing with a few upstream projects which rely on
>>     gtest for building their test suite in cmake.
>>
>>     Unfortunately, and unlike upstream recommendation to *not* rely
>>     precompiled binaries of gtest [1], upstream uses find_package(gtest)
>>     and links its test suite with the expected found libgtest and
>>     libgtest_main shared objects.
>>
>>     [1]
>>    
>> https://code.google.com/p/googletest/wiki/FAQ#Why_is_it_not_recommended_to_install_a_pre-compiled_copy_of_Goog
>>
>>
>>     Could you guys please point me to what you consider good examples of
>>     gtest integration with cmake and corresponding patching in Debian to
>>     use the gtest package within the archive?
>>
>>     Best regards,
>>     Ghislain
>>
>>
>>     --
>>     To UNSUBSCRIBE, email to debian-science-request@lists.debian.org
>>     <mailto:debian-science-request@lists.debian.org>
>>     with a subject of "unsubscribe". Trouble? Contact
>>     listmaster@lists.debian.org <mailto:listmaster@lists.debian.org>
>>     Archive: [🔎] 55C1D370.8070703@gmail.com">https://lists.debian.org/[🔎] 55C1D370.8070703@gmail.com
>>
>>
> 
> 


-- 
Jose Luis Rivero <jrivero@osrfoundation.org>


Reply to: