[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Looking for a sponsor for some robotics related packages



Hi Jose,

On Wed, Jan 15, 2014 at 02:29:11AM +0100, Jose Luis Rivero wrote:
> >Please, prepare git-patch for this debian-science meta-package  [1]. Add all of
> >these 4 packages.
> >
> >[1] http://anonscm.debian.org/gitweb/?p=blends/projects/science.git
> >
> 
> I could not find exactly the place were I should add sdformat nor
> any documentation related to the procedure

The long answer is

    http://blends.debian.org/blends

> so I just "use the force" and follow my instinct.

Valid apporach - but leaded to wrong result. ;-)

> I only add to debian-science-tasks.desc the libsdformat-dev.

debian-science-tasks.desc is an auto-generated file.  Please only
change the files matching tasks/*

> This package should install as dependency the whole
> family (-dev + lib) urdfdom and console-bridge.
> 
> Anton, Andreas, Thomas thanks for the help.
> Regards,
 
> diff --git a/debian-science-tasks.desc b/debian-science-tasks.desc
> index 75f074a..9d72fa5 100644
> --- a/debian-science-tasks.desc
> +++ b/debian-science-tasks.desc
> @@ -1340,6 +1340,7 @@ Packages: list
>   libode-dev
>   morse-simulator
>   robot-player
> + libsdformat-dev
> 
>  Task: science-simulations
>  Section: debian-science

As I said: wrong file to patch.  The correct patch is

diff --git a/tasks/robotics-dev b/tasks/robotics-dev
index 4209c1c..3ba2309 100644
--- a/tasks/robotics-dev
+++ b/tasks/robotics-dev
@@ -24,3 +24,6 @@ Depends: libopenigtlink-dev
 Depends: liburdfdom-dev
 
 Depends: libslicot-dev
+
+Depends: libsdformat-dev
+

Please also note that *-dev packages should go into robotics-dev


> diff --git a/tasks/robotics b/tasks/robotics
> index f7b7724..1147a49 100644
> --- a/tasks/robotics
> +++ b/tasks/robotics
> @@ -207,3 +207,47 @@ WNPP: 706133
>  Suggests: libcoin60-runtime, libvtk5.4
> 
>  Suggests: octave, gnuplot
> +
> +Depends: console-bridge
> +Homepage: https://github.com/ros/console_bridge
> +Responsible: Jose Luis Rivero <jrivero@osrfoundation.org>
> +License: BSD-3-clause
> +Pkg-Description: Console Bridge Library
> + ROS-independent, pure CMake (i.e. non-catkin and non-rosbuild
> + package) that provides logging calls that mirror those found in
> + rosconsole, but for applications that are not necessarily using ROS.

OK, took over

$ git diff
diff --git a/tasks/robotics b/tasks/robotics
index f7b7724..db50edf 100644
--- a/tasks/robotics
+++ b/tasks/robotics
@@ -207,3 +207,13 @@ WNPP: 706133
 Suggests: libcoin60-runtime, libvtk5.4
 
 Suggests: octave, gnuplot
+
+Depends: console-bridge
+Homepage: https://github.com/ros/console_bridge
+Responsible: Jose Luis Rivero <jrivero@osrfoundation.org>
+License: BSD-3-clause
+Pkg-Description: Console Bridge Library
+ ROS-independent, pure CMake (i.e. non-catkin and non-rosbuild
+ package) that provides logging calls that mirror those found in
+ rosconsole, but for applications that are not necessarily using ROS.
+


Please note:  This assumes that the *binary* package will be named
console-bridge (also see below)!


> +Depends: urdfdom
> +Homepage: https://github.com/ros/urdfdom
> +Responsible: Jose Luis Rivero <jrivero@osrfoundation.org>
> +License: BSD-3-clause
> +Pkg-Description: URDF DOM - model library
> + The URDF (U-Robot Description Format) library provides core data
> + structures and a simple XML parsers for populating the class data
> + structures from an URDF file.
> + .
> + This package contains the URDF DOM model library.
> +
> +Depends: urdfdom-headers
> +Homepage: https://github.com/ros/urdfdom_headers
> +Responsible: Jose Luis Rivero <jrivero@osrfoundation.org>
> +License: BSD-3-clause
> +Pkg-Description: URDF DOM - header files
> + The URDF (U-Robot Description Format) library provides core data
> + structures and a simple XML parsers for populating the class data
> + structures from an URDF file.
> + .
> + This package contains the headers files.

This is wrong and I replaced it by the way more simple but correct


diff --git a/tasks/robotics b/tasks/robotics
index db50edf..c424076 100644
--- a/tasks/robotics
+++ b/tasks/robotics
@@ -18,6 +18,8 @@ Depends: choreonoid
 
 Suggests: arduino-mk
 
+Depends: liburdfdom-tools
+
 Depends: solid
 WNPP: 500616
 Homepage: http://www.dtecta.com
diff --git a/tasks/robotics-dev b/tasks/robotics-dev
index 3ba2309..2ad33cb 100644
--- a/tasks/robotics-dev
+++ b/tasks/robotics-dev
@@ -21,7 +21,7 @@ WNPP: 706133
 
 Depends: libopenigtlink-dev
 
-Depends: liburdfdom-dev
+Depends: liburdfdom-dev, liburdfdom-headers-dev
 
 Depends: libslicot-dev
 

As you can see here you only need to specify *binary* package names!
This is the very same as you do in d/control file where you also do not
inject source package names.

Please also note that I added liburdfdom-tools to the robotics task
since this usually contains end user applications (and not only the
library).

Moreover you do not need to add any additional information if the
package is just injected into Vcs.  Since liburdfdom-dev was just
injected

commit b41d0fbab2d1784fa8ca528f3f62775f8c96b55b
Author: Andreas Tille <tille@debian.org>
Date:   Thu Jan 9 18:23:53 2014 +0100

    Added just injected liburdfdom-dev


(hey, I try to watch you all ;-)) you can see:

   http://blends.debian.org/science/tasks/robotics-dev#liburdfdom-dev

I hope this (repeated) explanation at another example makes things more
clear and proves that tasks files are simple maintainable once a package
has entered Vcs.  So make sure you adapt to the binary package names
once you injected console-bridge (and than you can remove the additional
information).  The tasks pages will adapt if the package might migrate
to new or finally ends up in main Debian.

Hope this helps

      Andreas. 

-- 
http://fam-tille.de


Reply to: