[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITP: pynac -- engine for symbolic geometric calculus for Python (Bug#678332)



Le 17/03/2013 12:42, Tobias Hansen a écrit :
- I'm not satisfied with the reason for the lintian override of
hardening-no-fortify-functions that hardening makes no sense. Since
-D_FORTIFY_SOURCE=2 is passed, this may be a false positive from
lintian, so that may be a better comment.

Done.

- Pass --disable-silent-rules to configure to get a more meaningful
build log.

Done.

- Install README

Done.

- Install NEWS as upstream changelog, instead of ChangeLog

Done.

- Tip for debian/copyright: you don't need to repeat the GPL2+ in every
file paragraph, one License:GPL2+ paragraph at the end would also do the
trick.

Done.


I can't help but notice that my debian/rules has:
DEB_CONFIGURE_EXTRA_FLAGS += --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)

and later on:
override_dh_auto_configure:
dh_auto_configure -- --enable-shared --disable-silent-rules --disable-static CPPFLAGS="$(CPPFLAGS) -D_LARGEFILE_SOURCE"

which makes me wonder how useful the variable really is (and yes, the lib is installed as multiarch)...

Perhaps that's a line I could remove?

Snark on #debian-science


Reply to: