[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#682893: RFS: freefoam/0.1.2-1 (for experimental)

Hello Michael,

Thank you for your work!

First small comment, instead of adding debian-science to CC, next time
use X-Debbugs-CC. The difference is: if in CC reply-all adds submit@ and
you get a loop of filing new bugs, in X-Debbugs-CC only
######@bugs.debian.org will be in the loop.

Now about the rest follows:

On 26/07/12 19:52, Michael Wild wrote:
> Package: sponsorship-requests
> Severity: normal
> Dear mentors,
> I am looking for a sponsor for my package "freefoam"
> * Package name    : freefoam
>   Version         : 0.1.2-1
>   Upstream Author : Michael Wild <themiwi@users.sourceforge.net>
> * URL             : http://freefoam.sourceforge.net
> * License         : GPL-3+ (+GFDL-NIV-1.2, permissive, PSF-2,
>                     LGPL-2.1+, BSD-4-clause, GPL-2)
>   Section         : science
> It builds those binary packages:
>   freefoam   - programs for Computational Fluid Dynamics (CFD)
>   freefoam-dbg - programs for Computational Fluid Dynamics (CFD) -
>     debugging symbols
>   freefoam-dev-doc - software for Computational Fluid Dynamics -
>     developers documentation
>   freefoam-user-doc - software for Computational Fluid Dynamics -
>     user documentation
>   libfreefoam - libraries for Computational Fluid Dynamics (CFD)
>   libfreefoam-dbg - libraries for Computational Fluid Dynamics (CFD) -
>     debugging symbols
>   libfreefoam-dev - libraries for Computational Fluid Dynamics (CFD) -
>     development files
>   python-freefoam - software for Computational Fluid Dynamics -
>     Python files
>   python3-freefoam - software for Computational Fluid Dynamics -
>     Python3 files
> To access further information about this package, please visit the
> following URL:
> http://mentors.debian.net/package/freefoam
> Alternatively, one can download the package with dget using this command:
>   dget -x
> http://mentors.debian.net/debian/pool/main/f/freefoam/freefoam_0.1.2-1.dsc
> More information about FreeFOAM can be obtained from
> http://freefoam.sourceforge.net.
> Changes since the last upload:
>   * [84c7923] New upstream version 0.1.2
>   * [162a878] Removed debian/patches/spelling.diff. Fixed in upstream.
>   * [881573d] Removed debian/patches/copyright.diff. This information
>     belongs into debian/copyright
>   * [d834177] Removed debian/patches/userd.diff, upstream removed that
>     part
>   * [86c646e] Build man-pages from source, remove pre-compiled copies in
>     debian/man1
>   * [0452a37] Build HTML version of UserGuide, depend on libjs-mathjax
>   * [e0e97d7] Added missing build-deps: graphviz
>   * [0a2c68d] Move to straight dh sequencer with parallel builds enabled
>     - The debhelper version present in Ubuntu precise doesn't contain
>       the fix for the CPPFLAGS variable being ignored by CMake
>       (#668813), so also add the manual workaround, just to make sure.
>     - Removed build-depends on cdbs
>     - Bumped minimum required version of debhelper to 7.0.50~.
>     - Keep dh_installchangelogs from trying to install doc/changes/ as
>       a file
>   * [63668d2] Split off Python module into python{,3}-freefoam, move to
>     dh_python*
>     - Changed build-dependency from python-all to simply python added
>       new
>     - Build-depends on python3
>     - Add X-Python{,3}-Version tags
>   * [59cd2fe] Install private binaries into /usr/lib/freefoam/bin
>   * [2a39577] Fix bogus lintian override
>   * [1240767] Cleanup debian/control, fix Homepage/Source entries
>   * [703e36b] Make debian/copyright complete, cleanup
>   * [b87d5f9] Do not version plugins directory
>   * [037f959] Properly assign files to correct package in
>     debian/*.install. Requires new build-depends on bash-completion.
>   * [2bdf7d5] Link docs of freefoam-{dev,user}-docs into
>     /usr/share/docs/freefoam
>   * [36a0288] Added debian/patches/disable-git-version-check.diff.
>     Instead of querying git about the build number, use the Debian
>     version.
>   * [981346d] Override warnings about useless ldconfig calls
>   * [e4c2b99] Add Michael Wild to the uploaders
>   * [02f2ab1] Added
>     debian/patches/fix-doc-urls-and-references-for-debian.diff.
>     Update the installation directories accordingly in
>     debian/freefoam-*-doc.install.
>   * [63e9652] Added
>     debian/patches/remove-hard-coded-python-modules-path.diff.
>     For the build to work it is now required to set the PYTHONPATH
>     environment variable in debian/rules.
>   * [06d66a3] Add multiarch support
>   * [658f053] Create debug-symbols packages {lib,}freefoam-dbg
>   * [13446a4] Build hardened libraries and executables. This requires
>     CMake/FOAMUtilities.cmake to be patched, otherwise it would be
>     impossible to pass the PIE flags to the executables only in CMake.
>     - Added d/p/add-DEB_EXE_COMPILE_LINKER_FLAGS-to-build-system.diff
>     - Added a build-depends on hardening-includes
> Gerber van der Graaf, who originally packaged the freefoam-0.1.0-1
> package asked me to add myself directly to the uploaders and asking for
> sponsorship instead of going through him.


> I think with the modifications I made I fixed some important bugs, some
> of which I would consider to be RC. E.g. 0.1.0-1 contained some non-free
> source and documentation files. Also, the documentation as it is
> currently installed is pretty buggy and does not work as expected. Also,
> the *.so symlinks where not split off into the libfreefoam-dev package
> and the Python files where not separated into python* packages.

currently there are no open RC bugs against the package.

If there are RC bugs (as per policy that is, not as per your own
standards ;-) ), please open them and use the correct Version: header.

> Some of these bugs I fixed directly in the upstream project, resulting
> in FreeFOAM-0.1.2, a pure bug-fix version. Then I imported this new
> upstream release, and applied all my fixes to the package, whose
> changelog you can see above.

The packaging changes are intrusive (e.g. introducing new binary
packages, new upstream release, packaging changes, etc). This is not
acceptable for a freeze exception, given that none of these things close
any of RC bugs.... (you should open them hint hint ;-) )

> Now, my question is how I should proceed properly. Is it acceptable to
> upload freefoam-0.1.2-1 despite the freeze given that the new version is
> only a bug-fix release?

It is fine to upload as it is into experimental.
It is fine to backport this into wheezy-backports, post release.
If you want some fixes in wheezy, open RC bugs, and fix said RC bugs
only (mini-packaging fork).


Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: