Re: RFS: givaro/3.7.1-1
Am Montag, den 16.07.2012, 09:35 +0800 schrieb Lifeng Sun:
> On 18:14 Sun 07/15/12 Jul , Daniel Leidert wrote:
> > I would suggest the following solution:
> > - rename givaro-user-doc to libgivaro-doc
> > - do not ship the developers documentation
> > - leave a pointer in README.Debian or TODO.Debian that you package the
> > developers documentation, if Debian users requests this
> I followed your proposal,
> * Rename givaro-user-doc to libgivaro-doc.
> * Remove givaro-dev-doc.
> * Provide instructions for users to generate developer's documentation
> in README.Debian.
> Thanks for your suggestion.
I saw, that the givaro*doc packages had already been uploaded. This
means, that you need to provide a transition path. IMHO you should empty
givaro-user-doc and givaro-dev-doc and make them depend on libgivaro-doc
and describe them as transitional packages.
The rest of the package looks good except for that the patches have no
description. Although you don't need to follow the DEP-3 patch tagging
guidelines I recommend to add at least a one-line description to what
the patches are supposed to do.
As soon as you've uploaded a fixed package to mentors.d.n, I'll sponsor
it for you.