[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Weird issue with bundler



You're welcome!

I tried locally and it fixed things for me, so I hope it will work on your side too.

Let me know if you run into issues though.

Yeah, the docs for `install_if` should definitely be improved. I'll work on that.

Hope you are well too, Daniel, in these odd times.

Best,

Deivid.

El 25/4/20 a las 21:14, Daniel Leidert escribió:
Am Samstag, den 25.04.2020, 19:22 +0200 schrieb deivid:

[..]
Anyways, by using `:install_if`, Bundler still considers all dependencies as
relevant for your current platform, and only at installation time it
restricts
installation by applying the `:install_if` condition.

A more correct default `Gemfile` for `jekyll` would include:

```
# Windows and JRuby does not include zoneinfo files, so bundle the
tzinfo-data gem
# and associated library.
platforms :mingw, :mswin, :jruby do
    gem "tzinfo", "~> 1.2"
    gem "tzinfo-data"
end

# Performance-booster for watching directories on Windows
gem "wdm", "~> 0.1.1", :platforms => [:mingw, :mswin]
```

I believe that with that default jekyll `Gemfile`, `bundler` will not
get in the
middle for `Debian` users, so I'll propose to change it in jekyll's
upstream.
And also fix our `:install_if` docs :sweat_smile:.
Thanks for the explanation. The docs don't mention this behavior for
install_if. I'll check if using platforms instead fixes the issue and patch
jekyll accordingly if it does. This would improve the situation a lot! Thanks
Deivid. I hope you are well and I'll see you at the next team sprint :)



Reply to: