Hey, On 11/08/19 10:21 pm, David Suarez wrote: > Hi, > > El dom., 11 ago. 2019 a las 4:56, Utkarsh Gupta > (<guptautkarsh2102@gmail.com>) escribió: > > On 11/08/19 2:23 am, David Suarez wrote: >> >> Sorry for being a pain, but while you're at it, could you take care of >> the following things as well? >> > All fixed, don't worry ! Perfect, thank you! Reviewed, all good now! :D Just added salsa-ci.yml to enable CI pipeline as well. > >> - In d/watch, use "version=4", instead of "version=3" and remove the >> commented lines pointing towards gemwatch. Most of the time, gemwatch >> doesn't ship test files, so we all know why that change :D > I prefer to maintain the comments; Mostly, because new people could > see the reason to switch > to gihub instead of the gem file. And, by the way, a pair of comments > doesn't hurts anybody :) Fine by me :D Best, Utkarsh
Attachment:
signature.asc
Description: OpenPGP digital signature