Re: Request review for ruby gem packages.

2016-01-14 16:01 GMT+08:00 Hleb Valoshka <375gnu@gmail.com>:

On 1/14/16, Andrew Lee <ajqlee@debian.org> wrote:

common issue:
compat sh'ld be 9, so debhlper version >= 9~

Right. Thanks for reminding.

> 1. ruby-combustion

install docs and templates
patch source_root (generator.rb) to use templates from proper place

Ok. I patched and pushed these changes. Please review for me.

> 2. ruby-appraiser-reek
and
> 3. ruby-appraiser-rubocop

you sh'ld package reek (>= 0), ruby-appraiser (>= 1.0.3)

Okay. I imported these two packages generated by gem2deb and filed ITP:

ruby-reek, ruby-appraiser. Would polish it and request review later.

use current long description instead of short one, expand a long one

Okay.

> 4. ruby-json-pure Not uploaded yet.

We already have this gem, see ruby-json

Okay. removed ruby-json-pure repo from git.d.o.

> 5. ruby-jeweler

Do you really need this package? It used only by ruby-cocoon/Rakefile
to generate new cocoon gem.

Okay. I'd confirm and get back to you later for this.

> 6. ruby-psych

in debian/ruby-tests.rake fix FileList['test/*_test.rb'] to
FileList['test/psych/test_*.rb']

After this change. It ftbfs with psych/helper load error.

Should I append DH_RUBY_IGNORE_TESTS=ruby2.2 or something also need to patch to fix this?

> 7. ruby-racc

As I noted previously we already have this gem.

Right. Removed repo from git.d.o.

Best regards,

-Andrew