Re: Request review for ruby gem packages.

[Hleb Valoshka <375gnu@gmail.com>]

On 12/19/15, Andrew Lee <ajqlee@debian.org> wrote:
> Would you mind to help to review again?

I drop a look on git snapshot of Dec 30, so some notes may be
outdated, I see you have updated some packages.

Common:
0. A lot of missing years in copyrights

> 1. ruby-acts-as-list, have you tried to build it?
> terceiro told me I should use https://rubygems.org/gems/acts_as_list
> instead.
> I have updated the package with acts_as_list, please recheck this for me.

- don't depend on bundler

- test/helper.rb showl look as
require "active_record"
require "minitest/autorun"
require "acts-as-list"
require "shared"

- you still need to add ruby-sqlite3 to Build-Depends

- fix debian/copyright


> 2. ruby-cliver.
>>     May be there is no need to install CONTRIBUTING.md it's useless
>> for end user.
>>     Specs are nor Rspec3 compatible use transpec to convert.
>>     Patch cliver.rb to use require "core_ext/file" instead of require
>> File.expand_path('../core_ext/file', __FILE__)
>>
>
> Done.

- previous fixed
- new introduced,  "bundler (>> 1.3), rake, ruby-rspec,
ruby-appraiser-reek,  ruby-appraiser-rubocop, yard" -- this should go
to Build-Depends, you should not using bundler (and no need to use
ruby-appraiser-reek,  ruby-appraiser-rubocop, yard -- but I'm not
sure)
- copyright has no year

>
> 3. ruby-clockwork.
>>     In specs remove require "rubygems" and replace require
>> File.expand_path('../../lib/clockwork', __FILE__) with require
>> "clockwork".
>>     Fix Depends: in debian/control.
>>     Install clockworkd.1 as manpage and example.rb as example.
>>
>
> Done.
>

- "bundler, rake, ruby-daemons, ruby-test-unit, ruby-minitest,
ruby-mocha" -- this should go to Build-Depends, you should not using
bundler


> 4. ruby-cocoon.
>>     Fix Depends and Build-Depends.
>>     In install_generator.rb you should patch source_root
>> File.expand_path('../templates', __FILE__), dunno what the proper
>> value is.
>>     Instead of adding History.md to docs install it using
>> override_dh_installchangelogs:
>>         dh_installchangelogs History.md -O--buildsystem=ruby
>>
>
> Done

 as with previuos packages, several packages are listed in depends
instead of build-depends


>
>> 5. ruby-codemirror-rails
>>     Don't embed 3rd party code (codemirror js/css) in your package.
>>
> Do you mean the files under vendor/?

yes

>>     Fix Depends and Build-Depends.
>>
> Fixed Depends. Don't know what's need to be fix in Build-Depends?

things marked as development, i.e. rails (>= 0, development), sqlite3
(>= 0, development), minitest (>= 0, development)

>
>> 6. ruby-innertube
>>     Remove from spec helper:
>> $: << File.expand_path('../../lib', __FILE__)
>> $: << File.expand_path('..', __FILE__)
>> require 'rubygems'
>>
>
> Done.

- remove  ruby-rspec (>> 2.10.0) from Depends
- fix links in descrition: [Riak Ruby
Client](/basho/riak-ruby-client), [Riak](/basho/riak)


>
>> 7. ruby-joiner
>>     Specs will not work w/o combustion, it's not packaged, consider
>> packaging.
>>
> What do you mean? You mean 'ruby-combustion' needs to be packaging as well?

yes

>
>>     Fix Depends and Build-Depends.
>>     Remove from spec helper:
>> require 'rubygems'
>> require 'bundler/setup'
>>
>
> Done.

ruby-combustion, ruby-rails, ruby-rspec-rails,  ruby-sqlite3 -- for
Build-Depends, not Depends

>
>> 8. ruby-jquery-datatables-rails
>>     As usual, fix Depends.
>>     3rd party data files should go into their own package, packages
>> from their upstream, and embedded copy should be removed.
>>
> What do you mean exactly?

consider packaging files in app/ to their our package, take them from
their upstream, or at least fix debian/copyright to reflect all
authors


>>     Ask somebody with good rail background to review. It seems to me
>> that you should patch install_generator.rb:
>>           js_manifest = 'app/assets/javascripts/application.js'
>>           css_manifest = 'app/assets/stylesheets/application.css'
>>
> Does anyone who has idea on how should this be patched?
>
>
>
>> 10. ruby-pundit
>>     Fix Depends and Build-Depends.
>>     Do end user really needs CONTRIBUTING.md and CODE_OF_CONDUCT.md?
>>
>
> Done.

- description: expand "oo"
- move several packages from depends to build-depends


>
>> 11. ruby-rails-tokeninput
>>     I'm not Rails expert, but do we actually need this package? It
>> does nothing in Rails 4.
>>     And jquery tokeninput scripts and stylesheets should not be embedded.
>>
> You mean app/?

yes
- move several packages from depends to build-depends, don't use bundler

>
>> 12. ruby-riddle
>>     Fix Depends and Build-Depends (ruby-mysql2).
>>     Install HISTORY as in ruby-cocoon.
>>     Remove from spec helper:
>> require 'rubygems'
>> require 'bundler'
>>
>> $:.unshift File.dirname(__FILE__) + '/../lib'
>> $:.unshift File.dirname(__FILE__) + '/..'
>>
>> Bundler.require :default, :development
>>
>
> Done.

rake, ruby-rspec, yard -- these thing has nothing to do in depends

>
>> 13. ruby-sprite-factory
>>     Fix Depends and Build-Depends
>>     Install RELEASE_NOTES.md the right way
>>     Fix require File.expand_path('../lib/sprite_factory',
>> File.dirname(__FILE__)) in test/test_case.rb
>>
>
>  Done.

  ruby-rmagick, ruby-chunky-png -- move to build-depends


> 14. ruby-thinking-sphinx
>>     Again, fix Depends and Build-Depends
>>
> I found we also need ruby-joiner?

yes

>
>>     Install HISTORY the right way
>>     Fix specs syntax for Rspec3 compatibility
>>
>     Remove from spec_helper:
>> require 'rubygems'
>> require 'bundler'
>
>
>> Bundler.require :default, :development
>>
>
> Done.

- ruby-combustion, ruby-database-cleaner, ruby-rspec -- move to BD
- ruby-appraisal - do you really need this one?
- description: remove starting article "a"

>
>> 15. ruby-xmlhash

-  ruby-pkg-config, rake-compiler, ruby-hoe -- move to BD
- possibly you sh'ld fix description