[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-test-unit-context



Hi Cedric,
Thanks for the suggestions. Will do them. However, I have some doubts.

Please consider removing the autogenerated debian/tests/control.ex file.

Can I remove the entire folder debian/tests if autopkgtest doesn't need any explicit directions? Or just the control.ex file? I was under the impression that debian/tests/control.ex was required for the autopkgtest to work. But then I read deeper and found out gem2deb changelog states that
autopkgtest can now automatically detect the Ruby tests.


In your copyright file, you use ASL-2.0 for the short name of the
Apache license, which should be instead Apache-2.0, according to
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
The full text of the license is not required to be cited, because it is
shipped in /usr/share/common-licenses/Apache-2.0. You should however add
a paragraph like:

On Debian systems, the full text of the Apache License version 2.0 can be
 found in the file `/usr/share/common-licenses/Apache-2.0'.

So the license portion will look like the following?
License: Apache-2.0
On Debian systems, the full text of the Apache License version 2.0 can be
 found in the file `/usr/share/common-licenses/Apache-2.0'

Also, is this applicable to all the licenses in /usr/share/common-licenses ? Should I just
say that the license can be found in that location?

In test/test_helper.rb, the $LOAD_PATH should probably be patched out,
so that the code installed under debian/ruby-test-unit-context would be
used instead of that of lib/ (although, since you don't modify files in
lib/, this would make no difference).

Yeah. I had also thought that. But didn't do it exactly because of the reason you stated.
If the convention is to patch out the $LOAD_PATH, I'll do that.

Also, is the Ruby team policy documented somewhere? Or is it existent only in mailing list archives?



--
Regards
Balasankar C
http://balasankarc.in


Reply to: