Re: RFS: ruby-mongo 1.8.5-1, ruby-bson-ext 1.8.5-1

[Prach Pongpanich <prachpub@gmail.com>]

On Fri, 19 Apr 2013 at 12:15:06 +0200, Cédric Boutillier wrote:
> Thank you for packaging this. I have a few remarks:

Thanks a lot for your suggestions.

> * you can safely target unstable instead of experimental in
>  debian/changelog: those packages have no version in testing, so the
>  introduction of a new version in unstable cannot cause any problem.

Updated, I target unstable.

>* It seems that there is a prefered form for the Vcs-* fields in
>  debian/control. For example, those for ruby-mongo would look like
>  this:
>  Vcs-Git: git://anonscm.debian.org/pkg-ruby-extras/ruby-mongo.git
>  Vcs-Browser: http://anonscm.debian.org/gitweb?p=pkg-ruby-extras/ruby-mongo.git;a=summary
>  It is reported with the latest version of lintian in experimental

Updated on both ruby-mongo and ruby-bson-ext.

> * For ruby-bson-ext, the short description should not end with a '.'
>   character

Fixed typo.

> * For ruby-mongo
>  - since you removed the content of debian/ruby-test-files.yaml, you
>    can remove the file completely. It seems that you can run at least
>    all tests in test/unit/ without mongodb server (except maybe
>    mongo_sharded_client_test.rb).
>    The loadpath has to be modified so that test_helper.rb can be found.
>    You can use the ruby-tests.rb method, with something like:
>
>    $: << "./test/"
>    Dir["test/unit/*.rb"].each { |f| require f}
>
>    (you'll need to add ruby-mocha and ruby-shoulda to the
>    Build-Depends: field, and maybe patch out the requirement on sfl in
>    test/tools/mongo_config.rb)

I have tried the mentioned above before I committed to the repository
and I removed debian/ruby-test-files.yaml file.
( I have learned a lot from your ruby-bson package. )

>  - you could install bin/mongo-console as an example through
>    debian/ruby-mongo.examples file instead of removing it completely

I already done it through debian/examples.


> After ruby-bson-ext is uploaded, ruby-bson can be updated to Recommend
> ruby-bson-ext.

I add a specific version of ruby-bson-ext (>= 1.8.5) in ruby-mongo and
ruby-bson (>= 1.8.5) in ruby-bson-ext.
(Upstream released three gems with the same version.)

Cheers,

Prach