Praveen A escreveu isso aí: > This transition work has been going on for some time, I'm happy to see > it ready. Ohai is not yet ported to ruby 1.9, so I'm building it for > ruby 1.8 only. The two failing tests are reported upstream [1], if > they fix it we can upload a new version for ruby 1.9. If anyone wants > help fix these two tests, I would be happy. I would rather not upload 1.8-only stuff right now. I've jusy pushed a commit that makes the package build for all supported versions, please review. The current master from github passes pretty much everything, except the tests for the 'ruby' plugin: they fail under 1.8 when 1.9 is the default, and under 1.9 when 1.8 is the default. I've sent a patch to fix this: https://github.com/opscode/ohai/pull/58 I would suggest to base the packaging on the rc release that was made very recenly, and adding the patches from the above pull request. > I had to migrate systemu, mixlib-config, mixlib-cli and mixlib-log; > and package yajl and sigar in preparation of this migration! I have > been on it for last 6 months! Yeah, this has been quite a journey! Thanks for your effort on this. > It runs all tests successfully with ruby 1.8. No it doesn't. Pay attention to the log you posted to the opscode ticket and you'll see that there is a crash and not all specs are run under 1.8: http://tickets.opscode.com/secure/attachment/10092/ohai-build-log.txt > It builds in a clean chroot and it is lintian clean. It has a large > variation of copyright terms too - so many contributors! > > Please review and upload. > > [1] http://tickets.opscode.com/browse/OHAI-327 Other points I found: Ignoring the require-rubygems test is not OK: when upstream code requires rubygems, that is a problem that needs to be fixed. Instead of ignoring the tests, you should add overrides for the false positives (refer to dh_ruby(1) for details). Will the current version of chef in unstable work with this new ohai? Are you going to update chef after? ;-) (in any case, if the current chef does not work with this new ohai, then we should prevent ohai from migrating to testing until we get a compatible chef). -- Antonio Terceiro <terceiro@debian.org>
Attachment:
signature.asc
Description: Digital signature