Vincent Fourmond escreveu isso aí: > On Fri, Jun 3, 2011 at 8:07 PM, Antonio Terceiro > <terceiro@softwarelivre.org> wrote: > >> Attached is another output of git-format-patch that does all of > >> that. Unless you spot something wrong in them, I'd be glad to merge > >> them myself to master this time ;-)... > > > > Very nice, thanks. Don't want to nitpick, but I didn't like the > > duplication of the test helper methods (assert_installed, build and > > friends). Any test helpers that are needed by more than one test class > > should be moved up to their superclass. > > > > BTW, if you use a proper branch to publish your changes in the > > repository itself (except the master branch), or even if you `git > > send-email` all the patches to the list, it would be easier for you and > > for me. :) > > Both done. I guess you shouldn't have difficulties finding the > proper branch ;-)... Sounds good, thanks. I suggest a small change on your tests to make the test output cleaner (see the attached patch). You can go ahead and merge this branch on master. Please delete the branch afterwards. -- Antonio Terceiro <terceiro@softwarelivre.org> http://softwarelivre.org/terceiro
From 87022a6e3a70d2108b7fe99dd5477a873ff6b472 Mon Sep 17 00:00:00 2001
From: Antonio Terceiro <terceiro@softwarelivre.org>
Date: Sat, 4 Jun 2011 14:05:33 -0700
Subject: [PATCH] Clean output of unit tests
setup.rb writes regular output to $stderr
---
test/unit/dh_rubysetuprb_test.rb | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/test/unit/dh_rubysetuprb_test.rb b/test/unit/dh_rubysetuprb_test.rb
index 190900a..1cb6b95 100644
--- a/test/unit/dh_rubysetuprb_test.rb
+++ b/test/unit/dh_rubysetuprb_test.rb
@@ -57,12 +57,14 @@ class DhRubySetuprbTest < Gem2DebTestCase
dh_ruby.verbose = false
silence_stream(STDOUT) do
- Dir.chdir(package_path) do
- # This sequence tries to imitate what dh will actually do
- dh_ruby.clean
- dh_ruby.configure
- dh_ruby.build
- dh_ruby.install File.join(package_path, 'debian', 'tmp')
+ silence_stream(STDERR) do
+ Dir.chdir(package_path) do
+ # This sequence tries to imitate what dh will actually do
+ dh_ruby.clean
+ dh_ruby.configure
+ dh_ruby.build
+ dh_ruby.install File.join(package_path, 'debian', 'tmp')
+ end
end
end
end
--
1.7.5.1
Attachment:
signature.asc
Description: Digital signature