Re: gem2deb: setup.rb branch ready for merging with master
On Fri, Jun 3, 2011 at 8:07 PM, Antonio Terceiro
<terceiro@softwarelivre.org> wrote:
>> Attached is another output of git-format-patch that does all of
>> that. Unless you spot something wrong in them, I'd be glad to merge
>> them myself to master this time ;-)...
>
> Very nice, thanks. Don't want to nitpick, but I didn't like the
> duplication of the test helper methods (assert_installed, build and
> friends). Any test helpers that are needed by more than one test class
> should be moved up to their superclass.
>
> BTW, if you use a proper branch to publish your changes in the
> repository itself (except the master branch), or even if you `git
> send-email` all the patches to the list, it would be easier for you and
> for me. :)
Both done. I guess you shouldn't have difficulties finding the
proper branch ;-)...
Cheers,
Vincent
Reply to: