[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kind of special transition for luajit{,2}?



On Sun, 2022-06-05 at 11:43 +0200, Paul Gevers wrote:
> 
> > sbuild --no-clean -c sid -d unstable love_11.3-1.dsc --extra-package ../luajit.pkg/
> > debc love_11.3-1_amd64.changes
> > 
> >   Package: love
> >   Version: 11.3-1
> >   Architecture: amd64
> >   Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
> >   Installed-Size: 4521
> >   Depends: libc6 (>= 2.33), libfreetype6 (>= 2.2.1), libgcc-s1 (>= 3.4), libluajit-5.1-2 | libluajit2-5.1-2 (>=
> > 2.0.4+dfsg), libmodplug1 (>= 1:0.8.8.5), libmpg123-0 (>= 1.28.0), libogg0 (>= 1.1.4~dfsg), libopenal1 (>= 1.14),
> 
> But if this is really the result of the rebuild. I think we just 
> discovered a serious flaw. The alternative dependency on libluajit-5.1-2 
> just lost its version constraint, as it's only added to libluajit2-5.1-2.

Ummmm... Yes, that's a good catch.

I fixed this versioned dependency issue with the following commit:
https://salsa.debian.org/lua-team/luajit/-/commit/561f846d9c84587ffff6715eef086aeb9ff0fd80
(pending to upload to unstable upon transition approval)

And the generated dependency looks like this:

 Package: love
 Version: 11.3-1
 Architecture: amd64
 Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
 Installed-Size: 4521
 Depends: libc6 (>= 2.33), libfreetype6 (>= 2.2.1), libgcc-s1 (>= 3.4), libluajit-5.1-2 (>= 2.0.4+dfsg) | libluajit2-
5.1-2 (>= 2.1~), libmodplug1 (>= 1:0.8.8.5), libmpg123-0 (>= 1.28.0), libogg0 (>= 1.1.4~dfsg), libopenal1 (>= 1.14),
libsdl2-2.0-0 (>= 2.0.12), libstdc++6 (>= 11), libtheora0 (>= 1.0), libvorbisfile3 (>= 1.1.2), zlib1g (>= 1:1.2.0)


> 
> To me (there are other Release Members more involved in transitions) 
> this feels a bit like an "add supported version" like we do for e.g. 
> Python and Ruby. Those are normally not interfering with other 
> transitions as any rebuilt binary can just migrate (once src:luajit2 is 
> in testing) on its own.
> 

Yes. Theoretically this won't break anything. FTBFS issues (if any) will
have different reasons.

> Please file the transition bug and I expect we can just proceed 
> (assuming my colleagues don't object), and that version issue is 
> investigated.
> 

The transition bug is opened here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012362
and the versioned depenency issue has been fixed in git.


Reply to: