Bug#779820: unblock (pre-approval): mate-netbook/1.8.1-4
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please consider unblocking of planned upload of package mate-netbook.
+ [ Martin Wimpress ]
+ * debian/patches:
+ + Add 0001_respect_undecorate_setting.patch. Ensure mate-maximus
+ undecorates maximized windows only when the "undecorate" dconf
+ option is set. (Closes: #778816).
Once mate-netbook is installed most applications loose their window
decorations when maximized (expected behabiour of mate-maximus inside the
mate-netbook package). In dconf there is a setting that allows one to
disable this "undecorate" behaviour (i.e. make windows behave normally
(desktop-like) again when maximized.
However, this "undecorate" option in dconf has no effect for users
attempting to disable the undecorate feature, window decorations stay
lost until mate-netbook gets uninstalled. Impossible to configure
mate-maximus on a per-user basis or with a system-wide override file.
With the provided patch in the attached .debdiff, this issue is fixed.
light+love,
Mike
unblock mate-netbook/1.8.1-4
-- System Information:
Debian Release: 8.0
APT prefers stable
APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
diff -Nru mate-netbook-1.8.1/debian/changelog mate-netbook-1.8.1/debian/changelog
--- mate-netbook-1.8.1/debian/changelog 2014-12-12 10:20:48.000000000 +0100
+++ mate-netbook-1.8.1/debian/changelog 2015-03-05 08:38:20.000000000 +0100
@@ -1,3 +1,13 @@
+mate-netbook (1.8.1-4) unstable; urgency=medium
+
+ [ Martin Wimpress ]
+ * debian/patches:
+ + Add 0001_respect_undecorate_setting.patch. Ensure mate-maximus
+ undecorates maximized windows only when the "undecorate" dconf
+ option is set. (Closes: #778816).
+
+ -- Mike Gabriel <sunweaver@debian.org> Thu, 05 Mar 2015 08:35:48 +0100
+
mate-netbook (1.8.1-3) unstable; urgency=medium
* Follow-up fix for #769417: Install mate-window-picker-applet to
diff -Nru mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch
--- mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch 1970-01-01 01:00:00.000000000 +0100
+++ mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch 2015-03-05 08:32:59.000000000 +0100
@@ -0,0 +1,22 @@
+From 90cfdef36b1140f7f75ada67ea0f22fe0d4d7f79 Mon Sep 17 00:00:00 2001
+From: Monsta <monsta@inbox.ru>
+Date: Fri, 9 Jan 2015 23:40:09 +0300
+Subject: [PATCH] mate-maximus: respect "undecorate" setting, goddammit
+
+---
+ maximus/maximus-app.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/maximus/maximus-app.c b/maximus/maximus-app.c
+index ea303d9..a1c4221 100644
+--- a/maximus/maximus-app.c
++++ b/maximus/maximus-app.c
+@@ -380,7 +380,7 @@ on_window_opened (WnckScreen *screen,
+
+ if (no_maximize || priv->no_maximize)
+ {
+- if (wnck_window_is_maximized(window))
++ if (wnck_window_is_maximized(window) && priv->undecorate)
+ {
+ _window_set_decorations (window, 0);
+ gdk_flush ();
diff -Nru mate-netbook-1.8.1/debian/patches/series mate-netbook-1.8.1/debian/patches/series
--- mate-netbook-1.8.1/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ mate-netbook-1.8.1/debian/patches/series 2015-03-05 08:32:59.000000000 +0100
@@ -0,0 +1 @@
+0001_respect_undecorate_setting.patch
Reply to: