[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779820: marked as done (unblock (pre-approval): mate-netbook/1.8.1-4)

Your message dated Sat, 28 Mar 2015 19:01:03 +0000
with message-id <1427569263.1708.19.camel@adam-barratt.org.uk>
and subject line Re: Bug#779820: unblock (pre-approval): mate-netbook/1.8.1-4
has caused the Debian Bug report #779820,
regarding unblock (pre-approval): mate-netbook/1.8.1-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
779820: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779820
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please consider unblocking of planned upload of package mate-netbook.

+  [ Martin Wimpress ]
+  * debian/patches:
+    + Add 0001_respect_undecorate_setting.patch. Ensure mate-maximus
+      undecorates maximized windows only when the "undecorate" dconf
+      option is set. (Closes: #778816).

Once mate-netbook is installed most applications loose their window
decorations when maximized (expected behabiour of mate-maximus inside the
mate-netbook package). In dconf there is a setting that allows one to
disable this "undecorate" behaviour (i.e. make windows behave normally
(desktop-like) again when maximized.

However, this "undecorate" option in dconf has no effect for users
attempting to disable the undecorate feature, window decorations stay
lost until mate-netbook gets uninstalled. Impossible to configure
mate-maximus on a per-user basis or with a system-wide override file.

With the provided patch in the attached .debdiff, this issue is fixed.

light+love,
Mike

unblock mate-netbook/1.8.1-4

-- System Information:
Debian Release: 8.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 'testing-proposed-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

diff -Nru mate-netbook-1.8.1/debian/changelog mate-netbook-1.8.1/debian/changelog
--- mate-netbook-1.8.1/debian/changelog	2014-12-12 10:20:48.000000000 +0100
+++ mate-netbook-1.8.1/debian/changelog	2015-03-05 08:38:20.000000000 +0100
@@ -1,3 +1,13 @@
+mate-netbook (1.8.1-4) unstable; urgency=medium
+
+  [ Martin Wimpress ]
+  * debian/patches:
+    + Add 0001_respect_undecorate_setting.patch. Ensure mate-maximus
+      undecorates maximized windows only when the "undecorate" dconf
+      option is set. (Closes: #778816).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Thu, 05 Mar 2015 08:35:48 +0100
+
 mate-netbook (1.8.1-3) unstable; urgency=medium
 
   * Follow-up fix for #769417: Install mate-window-picker-applet to
diff -Nru mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch
--- mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch	1970-01-01 01:00:00.000000000 +0100
+++ mate-netbook-1.8.1/debian/patches/0001_respect_undecorate_setting.patch	2015-03-05 08:32:59.000000000 +0100
@@ -0,0 +1,22 @@
+From 90cfdef36b1140f7f75ada67ea0f22fe0d4d7f79 Mon Sep 17 00:00:00 2001
+From: Monsta <monsta@inbox.ru>
+Date: Fri, 9 Jan 2015 23:40:09 +0300
+Subject: [PATCH] mate-maximus: respect "undecorate" setting, goddammit
+
+---
+ maximus/maximus-app.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/maximus/maximus-app.c b/maximus/maximus-app.c
+index ea303d9..a1c4221 100644
+--- a/maximus/maximus-app.c
++++ b/maximus/maximus-app.c
+@@ -380,7 +380,7 @@ on_window_opened (WnckScreen  *screen,
+ 
+   if (no_maximize || priv->no_maximize)
+   {
+-    if (wnck_window_is_maximized(window))
++    if (wnck_window_is_maximized(window) && priv->undecorate)
+     {
+       _window_set_decorations (window, 0);
+       gdk_flush ();
diff -Nru mate-netbook-1.8.1/debian/patches/series mate-netbook-1.8.1/debian/patches/series
--- mate-netbook-1.8.1/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ mate-netbook-1.8.1/debian/patches/series	2015-03-05 08:32:59.000000000 +0100
@@ -0,0 +1 @@
+0001_respect_undecorate_setting.patch

--- End Message ---
--- Begin Message --- 
On Sat, 2015-03-28 at 14:35 +0000, Mike Gabriel wrote:
> Control: tags -1 - moreinfo
> 
> Hi Emilio,
> 
> On  Fr 06 Mär 2015 13:52:17 CET, Emilio Pozuelo Monfort wrote:
> 
> > Control: tags -1 + confirmed
> >
> > On 06/03/15 13:18, Mike Gabriel wrote:
[...]
> >> The behaviour of mate-maximus should be controllable via gsettings  
> >> and not via
> >> dpkg (installation / removal of the package).
> >
> > OK. Based on that and the fact that the patch is trivial, and the  
> > issue seems important enough that I'd approve it for a pu in stable,  
> > I'm going to ack it now. Please upload it and remove the moreinfo  
> > tag when the package is accepted.
[...]
> I missed this mail. Sorry. Uploaded (+accepted in unstable) just now.

Unblocked.

Regards,

Adam

--- End Message ---
Reply to: