[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769404: marked as done (unblock: grilo-plugins/0.2.13-2)

Your message dated Sun, 16 Nov 2014 20:36:04 +0000
with message-id <20141116203604.GY6216@lupin.home.powdarrmonkey.net>
and subject line Re: Bug#769404: unblock: grilo-plugins/0.2.13-2
has caused the Debian Bug report #769404,
regarding unblock: grilo-plugins/0.2.13-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
769404: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769404
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package grilo-plugins

I'm about to upload the new package, which contains the following
fixes:

http://bugs.debian.org/769357

   There is a variable redefinition in the code that parses IPv6
   addresses that makes the plugin crash (in short: the code iterates
   over an uninitialized array). This renders programs like totem
   unusable.

http://bugs.debian.org/765986

   The dLeyna plugin uses the dleyna-server DBUS API, but the
   grilo-plugins package does not define any relationship to
   dleyna-server. This change adds a "Recommends: dleyna-server"
   field.

In addition to that, I added a build dependency on librest-dev. This
is a hard requirement for one of the plugins and the dependency is
explicitly checked in the configure script. If it's working at the
moment it's because it's coincidentally being pulled by other build
dependencies. I don't have any bug for this, so if this change is not
appropriate I'll revert it.

I haven't uploaded the package yet, I'll do it as soon as I get the
confirmation that the changes are fine.

Thanks!

unblock grilo-plugins/0.2.13-2

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru grilo-plugins-0.2.13/debian/changelog grilo-plugins-0.2.13/debian/changelog
--- grilo-plugins-0.2.13/debian/changelog	2014-08-27 14:48:24.000000000 +0300
+++ grilo-plugins-0.2.13/debian/changelog	2014-11-13 14:11:23.000000000 +0200
@@ -1,3 +1,13 @@
+grilo-plugins (0.2.13-2) unstable; urgency=medium
+
+  * debian/control:
+    - Add build dependency on librest-dev.
+    - Make grilo-plugins recommend dleyna-server (Closes: #765986).
+  * fix-dleyna-crash.patch:
+    - Fix crash due to variable redefinition (Closes: #769357).
+
+ -- Alberto Garcia <berto@igalia.com>  Thu, 13 Nov 2014 14:11:07 +0200
+
 grilo-plugins (0.2.13-1) unstable; urgency=medium
 
   * New upstream release (Closes: #750038).
diff -Nru grilo-plugins-0.2.13/debian/control grilo-plugins-0.2.13/debian/control
--- grilo-plugins-0.2.13/debian/control	2014-08-27 14:48:24.000000000 +0300
+++ grilo-plugins-0.2.13/debian/control	2014-11-13 14:11:23.000000000 +0200
@@ -10,6 +10,7 @@
                yelp-tools,
                python-dbusmock,
                libarchive-dev,
+               librest-dev (>= 0.7.90),
                libglib2.0-dev (>= 2.36),
                libgrilo-0.2-dev (>= 0.2.11),
                libxml2-dev,
@@ -36,6 +37,7 @@
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${shlibs:Depends},
          ${misc:Depends}
+Recommends: dleyna-server
 Description: Framework for discovering and browsing media - Plugins
  Grilo is a framework focused on making media discovery and browsing
  easy for application developers.
diff -Nru grilo-plugins-0.2.13/debian/patches/fix-dleyna-crash.patch grilo-plugins-0.2.13/debian/patches/fix-dleyna-crash.patch
--- grilo-plugins-0.2.13/debian/patches/fix-dleyna-crash.patch	1970-01-01 02:00:00.000000000 +0200
+++ grilo-plugins-0.2.13/debian/patches/fix-dleyna-crash.patch	2014-11-13 14:11:23.000000000 +0200
@@ -0,0 +1,16 @@
+From: Juan A. Suarez Romero <jasuarez@igalia.com>
+Subject: Remove variable redefinition
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=740052
+Bug-Debian: https://bugs.debian.org/769357
+Index: grilo-plugins/src/dleyna/grl-dleyna-utils.c
+===================================================================
+--- grilo-plugins.orig/src/dleyna/grl-dleyna-utils.c
++++ grilo-plugins/src/dleyna/grl-dleyna-utils.c
+@@ -213,7 +213,6 @@ is_our_user_ipv6 (struct sockaddr_in6 *a
+ 
+   status = g_io_channel_read_line (file, &line, NULL, NULL, NULL);
+   while (status == G_IO_STATUS_NORMAL) {
+-    char *line;
+     int j, k, l;
+     /* 4*8 for IP, 4 for port, 1 for :, 1 for NUL */
+     char buffer[4*8 + 4 + 1 + 1];
diff -Nru grilo-plugins-0.2.13/debian/patches/series grilo-plugins-0.2.13/debian/patches/series
--- grilo-plugins-0.2.13/debian/patches/series	1970-01-01 02:00:00.000000000 +0200
+++ grilo-plugins-0.2.13/debian/patches/series	2014-11-13 14:11:23.000000000 +0200
@@ -0,0 +1 @@
+fix-dleyna-crash.patch

--- End Message ---
--- Begin Message --- 
On Sun, Nov 16, 2014 at 07:12:45PM +0200, Alberto Garcia wrote:
> On Sun, Nov 16, 2014 at 03:48:04PM +0000, Jonathan Wiltshire wrote:
> 
> > > Given the changes are small, seem to match the freeze policy, and
> > > can anyway be reverted later if needed: if I were you, I would
> > > skip the pre-approval procedure, upload to sid and then ping this
> > > bug to avoid more round-trips.
> 
> I updated the changelog message as suggested and uploaded the package,
> here's the debdiff.

Thanks, adsb has unblocked it.

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: