[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#769404: unblock: grilo-plugins/0.2.13-2



Hi Alberto,

[I'm not on the release team, so take my comments with a grain of salt.]

Alberto Garcia wrote (13 Nov 2014 12:56:29 GMT) :
> I'm about to upload the new package, which contains the following
> fixes:
[...]

Both the scope of the proposed upload and the size of the diff look
appropriate to me. I can't comment on the actual code changes, though.

> In addition to that, I added a build dependency on librest-dev. This
> is a hard requirement for one of the plugins and the dependency is
> explicitly checked in the configure script. If it's working at the
> moment it's because it's coincidentally being pulled by other build
> dependencies. I don't have any bug for this, so if this change is not
> appropriate I'll revert it.

IMO it's appropriate, but I would suggest documenting this change more
thoroughly in debian/changelog before uploading.

> I haven't uploaded the package yet, I'll do it as soon as I get the
> confirmation that the changes are fine.

Given the changes are small, seem to match the freeze policy, and can
anyway be reverted later if needed: if I were you, I would skip the
pre-approval procedure, upload to sid and then ping this bug to avoid
more round-trips.

Cheers,
--
intrigeri


Reply to: