В Tue, 9 Oct 2012 19:50:04 +0200 Julien Cristau <jcristau@debian.org> пишет: > On Tue, Oct 9, 2012 at 17:56:47 +0400, Alexander Golovko wrote: > > > В Tue, 9 Oct 2012 12:32:07 +0200 > > Julien Cristau <jcristau@debian.org> пишет: > > > > > On Tue, Oct 9, 2012 at 13:17:23 +0400, Alexander Golovko wrote: > > > > > > > 1. Build packages for all database types in the same time, not a > > > > separate process for sqlite3, mysql and pgsql. > > > > > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=1ca440fc3758a28fdcd17c05aa24f724934dbc5f > > > > > > > nak. > > > > I try to convince you again, if you don't mind. > > > ok, I guess I'll take your word for it. i'm sorry for my english, but what you mean? That you allow this change or that it rejected and i should not continue try to change you opinion? > > > > > > 3. fix daemons user/group on systems with systemd (Closes: > > > > #679958). delegate daemons uid/gid changing to > > > > start-stop-daemon or systemd, thanks to Matija Nalis (Closes: > > > > #556207). > > > > > > > > This changes are related and intersected. First commit reverted > > > > by last. > > > > > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6 > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1 > > > > http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8 > > > > > > > > Upstream already much time (at least since 2010, Oct) use > > > > start-stop-daemon for change daemons uid/gid in their variant of > > > > init scripts. Our patch for uid/gid changing by systemd was > > > > already accepted into upstream. > > > > > > > > The big problem, that without this change user can't simply get > > > > backtraces on daemons crashes. This backtraces required for some > > > > bugreport to upstream. > > > > > > > Meh. Can't the systemd files be simply removed? If this doesn't > > > affect sysvinit systems I would prefer not to bother. > > > > Hmm. But systemd service files was added to package in 5.2.6+dfsg-1 > > via bug #624532. And patch for fix them is trivial. > > > Apparently not so trivial, since it needs a fixup now. I would rather > not see a change that affects all paths to fix something for the .1% > of users that run systemd. ohh. i think, that will be better to split explanation of this change into two parts. First - changes in sysvinit scripts. Instead of run daemons as root and pass options for chuid we allow start-stop-daemon to run it as non-root. This is what do upstream and without this fix we have a problems with getting backtraces on daemons crashes. Second - changes in systemd service files. In 5.2.6+dfsg-1 our team add this files into packages, but unfortunely, they was shipped with incorrect (empty) uid/gid in them. So, for systemd service files was fixed two problems: a) Change daemons uid/gid by systemd, as do sysvinit scripts. This is separate patch [1] for simplicity sending it to upstream (already accepted by upstream) b) Fixing incorrect uid/gid. Due to limitation of upstream build system we can't use build options and hardcore uid/gid by patch [2] [1] http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/delegate-chuid-to-systemd.patch [2] http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=blob;f=debian/patches/fix-systemd-daemon-user-group.patch As i understand, your opinion is that will be better do not ship systemd service files at all, but include changes in sysvinit scripts? > > > > 8. make package purging more careful about users files. > > > > > > > Don't really see the point of this one. Purging means purging. > > > > actually, this is a difference from squeeze behavior for > > bacula-director packages. Revert anyway? > > > That would be my preference, yes. ok. i revert it. > > > > 16. Cleanup list of linked libraries. > > > > > > > nak. > > > > Maybe i incorrect worded this change. > > This change remove unused libraries (no symbols from library used) > > from list of linked libraries. > > > I know what --as-needed does. It's essentially cosmetic, not > appropriate during the freeze. ok. i revert it. > > And the next question. > > Currently bacula can't built on hurd platforms. Should i include > > fix for this problem into next upload, intended for wheezy or not? > > > If the patch is small and obvious enough why not, but hurd won't make > wheezy so it's not really needed from our perspective. In fact this is depend on upstream. There was a little changes in package (disabled acl, xattr and mtx on this platform) and i wait while upstream fix problems with maximum path length on this platform. I will ask this additionally, when upstream prepare patch. Upstream recommend do not use hardening for bacula, so we have 71 lintian warning about this fact. In git master branch this warnings was hidden by adding lintian-overrides. This is cosmetic change and should not present in next upload, intended for wheezy? What is the best way to prepare package without rejected changes? Should i upload new package into sid and reopen bugs with rejected fixes or i should upload it directly (but how?) into wheezy? > > Thanks for your work. > > Cheers, > Julien -- with best regards, Alexander Golovko email: alexandro@ankalagon.ru xmpp: alexandro@ankalagon.ru
Attachment:
signature.asc
Description: PGP signature