[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689003: unblock: bacula/5.2.6+dfsg-5



On Tue, Oct  9, 2012 at 13:17:23 +0400, Alexander Golovko wrote:

> 1. Build packages for all database types in the same time, not a
> separate process for sqlite3, mysql and pgsql.
> 
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=1ca440fc3758a28fdcd17c05aa24f724934dbc5f
> 
nak.

> 2. Save all file xattrs, not only first (Closes: #688732),
> Fix bacula-fd crash on saving xattr on btrfs.
> 
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=455622199fb46805cd11f69630279af5987c0bb2
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d7bb353b616c6221684ffc81cbfe2c885a1dab81
> 
> It is a regression since squeeze. Squeeze shipped with previous major
> version of bacula. There are a big commits, but however this is
> only adding upstream patch. I'm think, there is important bugfix.
> 
I would tend to agree.

> 3. fix daemons user/group on systems with systemd (Closes: #679958).
> delegate daemons uid/gid changing to start-stop-daemon or systemd,
> thanks to Matija Nalis (Closes: #556207).
> 
> This changes are related and intersected. First commit reverted by
> last.
> 
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=d077cd3c71734828b635f8605c8411f6cd86b6f6
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=cf9eb640182f4adfd83d05954dc35a20b60170c1
> http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commit;h=694b788e0f82a734ca98bb0930a97432240c7fe8
> 
> Upstream already much time (at least since 2010, Oct) use
> start-stop-daemon for change daemons uid/gid in their variant of init
> scripts. Our patch for uid/gid changing by systemd was already accepted
> into upstream. 
> 
> The big problem, that without this change user can't simply get
> backtraces on daemons crashes. This backtraces required for some
> bugreport to upstream.
> 
Meh.  Can't the systemd files be simply removed?  If this doesn't
affect sysvinit systems I would prefer not to bother.

> 4. fix waiting for real daemon stopping (Closes: #684744).
> remove unused code from bacula-director init script.
> 
ack.

> 5. Add build-depends for read-all capability support (Closes: #683080).
> 
A bit nervous about this one.  How much has this been tested, and how
likely is it to affect unrelated features?

> 6. don't remove bacula user on package purging (details in bug 621833).
> 
ack.

> 7. fix files left after packages purge (thanks to piuparts).
> 
ack.

> 8. make package purging more careful about users files.
> 
Don't really see the point of this one.  Purging means purging.

> 9. fix bacula log directory (Closes: #684203).
> 
ack.

> 10. force /etc/defaults/bacula-dir reregistration in ucf when
> changing bacula-director database type, fix purging after this
> (Closes: #680051).
> 
Not sure about this, would appreciate advice from somebody who knows
ucf.

> 11. switch to /run directory
> 
nak.

> 12. Fix impossibility to run out-of-box scripts make_mysql_tables and
> update_mysql_tables scripts, shipped with package (#679855).
> 
Are these scripts ever run automatically by the package?

> 13. switch from usermod to more debian-policy friendly adduser.
> 
Unless this is fixing an actual bug, nak.

> 14. fix hostname substitution (Closes: #682966).
> 
Doesn't seem critical?

> 15. add bacula into cdrom group (Closes: #520508).
> 
Same here, I'd say defer to wheezy+1.

> 16. Cleanup list of linked libraries.
> 
nak.

> 17. Add build-depends for LZO support.
> 
nak.

> 16. Improve the use of English (thanks to debian-l10n-english team).
> 
I guess this should be ok...

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: