Bug#683299: unblock: open-vm-tools/2:8.8.0+2012.05.21-724730-3
On 07/31/2012 11:07 AM, Bernd Zeimetz wrote:
> so yet again you managed to make a mess of open-vm-tools short time
> before a release.
i didn't. please read the whole thread carefully, thank you.
> + * Switching to xz compression.
>
> Why?
smaller package size.
> Is this really release critical?
this is part of the -2 upload before the freeze (as everything else
except the last dkms ftbfs fix), it's a regular maintainer upload.
> + * Loading modules through kmod instead of initscript.
>
> The initscript way was always ugly, but it is known to work. Why change
> it short before the release?
because it's better and less error prone.
> I doubt its well tested enough.
it is.
> + * Adding sleep during restart in initscript.
>
> Why one second?
because it sometimes fails to restart if there's no sleep.
> Is it enough?
yes.
> Is there a proper way instead of sleeping?
to the best of my knowledge, this is the proper way these days on how do
deal with these sort of things in sysvinit initscripts.
> + * Removing old dpkg trigger for update-initramfs.
>
> See above. How can you be sure it was well enough tested?
dpkg dropped support for update-initramfs triggers in debian/*triggers,
the trigger file therefore is entirely useless. you need to call
update-initramfs in postinst manually, like the package already does
since a long time.
--
Address: Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email: daniel.baumann@progress-technologies.net
Internet: http://people.progress-technologies.net/~daniel.baumann/
Reply to: