[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683299: unblock: open-vm-tools/2:8.8.0+2012.05.21-724730-3



[ CCing da-manager@ to make sure they know that you still fail in
maintaining your packages properly ]

Hi,

so yet again you managed to make a mess of open-vm-tools short time
before a release. open-vm-tools is essential for a lot of people,
running thousands of machines running Debian in a vmware environment -
and not in a simple desktop virtualization. So I think you should
finally pass the package into the hands of somebody who is willing to
maintain it properly and test changes early enough to ensure they make
their way into the next release. Actually I'm wondering if you even have
a proper environment to test the package properly.

On 07/31/2012 03:30 AM, Daniel Baumann wrote:
> On 07/31/2012 01:50 AM, Daniel Baumann wrote:
>> there's nothing i can do about it except asking you to unblock said version, which i did.
> 
> almost.. in addition to what the other people on the thread[0] already
> said.. here are the individual git commits as patches attached,
> constituting the complete diff between wheezy and sid.
> 
> the actual diff for anything that wasn't unblocked/freeze-exempted
> before already, is patch 8 only (and patch 9 for the changelog entry).
> 
> [0] http://lists.debian.org/debian-release/2012/07/msg01706.html

To add some of my comments to your changelog:

+  * Switching to xz compression.

Why? Is this really release critical?

+  * Loading modules through kmod instead of initscript.

The initscript way was always ugly, but it is known to work. Why change
it short before the release? I doubt its well tested enough.

+  * Adding sleep during restart in initscript.

Why one second? Is it enough? Is there a proper way instead of sleeping?

+  * Removing old dpkg trigger for update-initramfs.

See above. How can you be sure it was well enough tested?

+  * Updating GPL boilerplate in copyright file.

Well, seems the copyright file was buggy, so yes, I guess this change
makes sense.


+  * Calling dh_dkms with version argument (Closes: #677503).
+  [ Thijs Kinkhorst ]
+  * Updating dkms.conf to make modules build again, thanks to H.A.J.
+    Koster (Closes: #679886).

These two look like the only real fixes which need to be done at this
point of time before the release. Probably you should upload a package
with these three changes, send excuses for your behaviour to the release
team and ask them in a nice way to accept the changes. Of course you
should document why they are necessary and send the patches. Like
everybody else does.

If you are not willing to do so, please orphan the package so somebody
who has the time to maintain it and who is able to fix bugs during the
freeze in a manner which would be appropriate for a Debian developer
(and which is far far far away from what you are showing here).

Best regards,

Bernd

-- 
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F


Reply to: