[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Proposed update to cron for Wheezy - freeze exception request



Dear Release Managers,

I have prepared a new cron release (3.0pl1-124) which includes fixes for the
following bugs:

 - #679106 - critical - /etc/init.d/cron stop may kill unrelated processes
 - #679062 - important - remove obsolete /etc/cron.daily/standard on upgrade

It also includes some minor fixes (documentation and/or lintian fixes). All
the changes have been pushed to Debian cron's GIT repository [1].

Since this version fixes the above bugs I would like to ask the Release Team
to grant a freeze exception for this version.

I'm attaching the diff between both .diff.gz (generated using interdiff -z)
as well as a debdiff between the new package and the previous version for
your consideration.

Please let me know if I can upload this new package version to unstable.

Thanks

Javier


[1] http://anonscm.debian.org/gitweb/?p=pkg-cron/pkg-cron.git
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)
------------------------------------------------
 This cron package [-is configured by default to do some basic daily-] {+does not provide any+} system maintenance tasks. [-Other-] {+Basic+}
{+ periodic maintenance tasks are provided by other+} packages, such
 as [-checksecurity, can provide further-]
[- maintenance tasks.-] {+checksecurity.+}
Installed-Size: [-297-] {+298+}
Version: [-3.0pl1-123-] {+3.0pl1-124+}
diff -u cron-3.0pl1/debian/postinst cron-3.0pl1/debian/postinst
--- cron-3.0pl1/debian/postinst
+++ cron-3.0pl1/debian/postinst
@@ -30,8 +30,9 @@
     fi
 done
 
-# Conffile has become obsolete
+# Conffiles that are now obsolete
 dpkg-maintscript-helper rm_conffile /etc/cron.monthly/standard "3.0pl1-113" -- "$@"
+dpkg-maintscript-helper rm_conffile /etc/cron.daily/standard "3.0pl1-123" -- "$@"
 # If dpkg-maintscript-helper renames it instead of removing it because it has
 # local modifications, we must rename it back to a valid name, or crond
 # will not accept it. Thanks to Raphaël Hertzog for the tip.
diff -u cron-3.0pl1/debian/postrm cron-3.0pl1/debian/postrm
--- cron-3.0pl1/debian/postrm
+++ cron-3.0pl1/debian/postrm
@@ -1,8 +1,9 @@
 #!/bin/sh
 set -e
 
-# Conffile has become obsolete
+# Conffiles that are now obsolete
 dpkg-maintscript-helper rm_conffile /etc/cron.monthly/standard "3.0pl1-113" -- "$@"
+dpkg-maintscript-helper rm_conffile /etc/cron.daily/standard "3.0pl1-123" -- "$@"
 
 if [ "$1" = "purge" ]; then 
     rm -f /etc/cron.allow /etc/cron.deny
diff -u cron-3.0pl1/debian/control cron-3.0pl1/debian/control
--- cron-3.0pl1/debian/control
+++ cron-3.0pl1/debian/control
@@ -3,9 +3,9 @@
 Priority: important
 Maintainer: Javier Fernández-Sanguino Peña <jfs@debian.org>
 Uploaders: Christian Kastner <debian@kvr.at>
-Standards-Version: 3.9.2
+Standards-Version: 3.9.3
 Build-Depends:
-    debhelper (>= 7.2.3~),
+    debhelper (>= 9),
     libpam0g-dev,
     libselinux1-dev [linux-any],
     libaudit-dev [linux-any]
@@ -46,3 +46,3 @@
- This cron package is configured by default to do some basic daily system
- maintenance tasks. Other packages, such as checksecurity, can provide further
- maintenance tasks.
+ This cron package does not provide any system maintenance tasks. Basic
+ periodic maintenance tasks are provided by other packages, such 
+ as checksecurity.
diff -u cron-3.0pl1/debian/changelog cron-3.0pl1/debian/changelog
--- cron-3.0pl1/debian/changelog
+++ cron-3.0pl1/debian/changelog
@@ -1,3 +1,22 @@
+cron (3.0pl1-124) unstable; urgency=medium
+
+  [ Release targeted to Wheezy including fixes for critical/important bugs ]
+  * debian/{preinst,postinst,postrm}: remove obsolete /etc/cron.daily/standard
+    on upgrade. (Closes: #679062)
+  * debian/cron.init: Have the init.d file remove cron's pidfile if it 
+    exists after killing the process. The pidfile should be removed
+    by cron itself (but it isn't) through its SIGhandler as done in later
+    versions in cron (4.1 and cronie). This fix is, however, simpler and less
+    intrusive. (Closes: 679106, 615855)
+  * debian/control:  
+       - Reword last paragraph since cron does not provide any standard tasks
+         anymore. (Closes: 674192)
+       - Update to Standards-Version: 3.9.3 - which BTW includes an indication
+         on which are the valid cron filenames.
+       - Depend on debhelper >= 9 (lintian warning)
+
+ -- Javier Fernández-Sanguino Peña <jfs@debian.org>  Thu, 28 Jun 2012 12:08:09 +0200
+
 cron (3.0pl1-123) unstable; urgency=low
 
   * debian/standard.daily: Apply patch from Steve Allison to prevent checking
@@ -19,7 +38,7 @@
   * debian/control:
     - Put the maintainer address in UTF-8 encoding
   * debian/postinst:
-     - Only go ahead when configuring the package (Closes: #653304)
+     - Only go ahead when configuring the package (Closes: #653304, #657073)
   * debian/source/lintian-overrides:
     - Removed, no longer required
   * crontab.5:
@@ -198,7 +217,7 @@
     - Backup of /etc/{passd,group} is no longer performed by cron; the task
       was handed over to src:shadow (see #554170). In Squeeze, this task will
       be performed redundantly by both packages (as discussed on
-      debian-release)
+      debian-release) (Closes: 333837)
     - Rewrite locking and lost+found-checking code, based on a submission to
       the BTS by Justin B. Rye. Closes: #478967, #537073, LP: #257367
     - Parse /etc/mtab instead of /proc/mounts; the former makes handling bind
diff -u cron-3.0pl1/debian/preinst cron-3.0pl1/debian/preinst
--- cron-3.0pl1/debian/preinst
+++ cron-3.0pl1/debian/preinst
@@ -2,6 +2,7 @@
 set -e
 
-# Conffile has become obsolete
+# Conffiles that are now obsolete
 dpkg-maintscript-helper rm_conffile /etc/cron.monthly/standard "3.0pl1-113" -- "$@"
+dpkg-maintscript-helper rm_conffile /etc/cron.daily/standard "3.0pl1-123" -- "$@"
 
 #DEBHELPER#
diff -u cron-3.0pl1/debian/cron.init cron-3.0pl1/debian/cron.init
--- cron-3.0pl1/debian/cron.init
+++ cron-3.0pl1/debian/cron.init
@@ -70,7 +70,9 @@
 	;;
 stop)	log_daemon_msg "Stopping periodic command scheduler" "cron"
         killproc -p $PIDFILE $DAEMON
-        log_end_msg $?
+        RETVAL=$?
+        [ $RETVAL -eq 0 ] && [ -e "$PIDFILE" ] && rm -f $PIDFILE
+        log_end_msg $RETVAL
         ;;
 restart) log_daemon_msg "Restarting periodic command scheduler" "cron" 
         $0 stop

Attachment: signature.asc
Description: Digital signature


Reply to: