On Thu, 2012-01-19 at 22:09 +0000, Adam D. Barratt wrote: > > To be clear, there are three changes up for consideration: > > > > (1) is #645599 which is essentially: > > http://arthurdejong.org/viewvc/nss-pam-ldapd/nss-pam-ldapd-0.7/debian/libnss-ldapd.config?r1=1209&r2=1555 > > (2) is a problem with not-initialised variables which is: > > http://arthurdejong.org/viewvc/nss-pam-ldapd/nss-pam-ldapd-0.7/nslcd/nslcd.c?r1=1209&r2=1559 > > (3) is a typo in error handling code: > > http://arthurdejong.org/viewvc/nss-pam-ldapd/nss-pam-ldapd-0.7/nslcd/myldap.c?r1=1469&r2=1561 > > Those are the changes I was referring to above when I said I'd be happy > to look at them, yes. Thanks. > The range checking patch could be okay, although given that we're > getting quite close to the end of the window for 6.0.4 I'm tempted to > say we'll look at it for a future update. Ok. > Are any of the other changes you mentioned which are fixed in 0.8 and > aren't particularly intrusive easily reviewable? The other fixes aren't in a released version yet so they will have to wait. > As I mentioned, the latter would be preferable as it makes the diff much > cleaner, targetted and easier to review. In retrospect, we possibly > should have raised that for the earlier updates. Ok, thanks. I've also been giving it some thought also and a 0.7.15+squeeze1 version would also allow me with some more freedom to release a new upstream 0.7.16 (not targeted at Debian). Please let me know if you want me to prepare a debdiff or do an upload and with which changes. Thanks for looking into this. -- -- arthur - adejong@debian.org - http://people.debian.org/~adejong --
Attachment:
signature.asc
Description: This is a digitally signed message part